You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@orc.apache.org by do...@apache.org on 2021/07/27 17:34:56 UTC
[orc] branch branch-1.7 updated: ORC-873: Fix FindCyrusSASL to use
the package name CyrusSASL (#783)
This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch branch-1.7
in repository https://gitbox.apache.org/repos/asf/orc.git
The following commit(s) were added to refs/heads/branch-1.7 by this push:
new 6861ca6 ORC-873: Fix FindCyrusSASL to use the package name CyrusSASL (#783)
6861ca6 is described below
commit 6861ca61f0e440260a04f69acd6a89b07a427f6b
Author: Dongjoon Hyun <do...@apache.org>
AuthorDate: Tue Jul 27 10:21:35 2021 -0700
ORC-873: Fix FindCyrusSASL to use the package name CyrusSASL (#783)
### What changes were proposed in this pull request?
This PR aims to use the package name `CyprusSASL` at `find_package_handle_standard_args`.
```cmake
-find_package_handle_standard_args(CYRUS_SASL DEFAULT_MSG
+find_package_handle_standard_args(CyrusSASL DEFAULT_MSG
```
### Why are the changes needed?
Currently, it shows a warning like the following.
```
CMake Warning (dev) at /opt/homebrew/Cellar/cmake/3.21.0/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:438 (message):
The package name passed to `find_package_handle_standard_args` (CYRUS_SASL)
does not match the name of the calling package (CyrusSASL). This can lead
to problems in calling code that expects `find_package` result variables
(e.g., `_FOUND`) to follow a certain pattern.
Call Stack (most recent call first):
cmake_modules/FindCyrusSASL.cmake:46 (find_package_handle_standard_args)
cmake_modules/ThirdpartyToolchain.cmake:432 (find_package)
CMakeLists.txt:130 (INCLUDE)
This warning is for project developers. Use -Wno-dev to suppress it.
```
### How was this patch tested?
After passing the CIs, manually check the C++ build.
(cherry picked from commit 147e005e8c73491cc90074531239329a53675e1f)
Signed-off-by: Dongjoon Hyun <do...@apache.org>
---
cmake_modules/FindCyrusSASL.cmake | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cmake_modules/FindCyrusSASL.cmake b/cmake_modules/FindCyrusSASL.cmake
index 8ce027f..6294dad 100644
--- a/cmake_modules/FindCyrusSASL.cmake
+++ b/cmake_modules/FindCyrusSASL.cmake
@@ -43,7 +43,7 @@ find_path(CYRUS_SASL_INCLUDE_DIR sasl/sasl.h)
find_library(CYRUS_SASL_SHARED_LIB sasl2)
include(FindPackageHandleStandardArgs)
-find_package_handle_standard_args(CYRUS_SASL DEFAULT_MSG
+find_package_handle_standard_args(CyrusSASL DEFAULT_MSG
CYRUS_SASL_SHARED_LIB CYRUS_SASL_INCLUDE_DIR)
MARK_AS_ADVANCED(CYRUS_SASL_INCLUDE_DIR CYRUS_SASL_SHARED_LIB)