You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@plc4x.apache.org by GitBox <gi...@apache.org> on 2019/01/16 20:27:28 UTC

[GitHub] timbo2k commented on issue #44: S7: changed byteLength and blockNumber from short to int

timbo2k commented on issue #44: S7: changed byteLength and blockNumber from short to int
URL: https://github.com/apache/incubator-plc4x/pull/44#issuecomment-454927820
 
 
   Hi Chris
   
   I think there are also block number > 32000 possible (see attached screenshot from a recently added block with the number 50000), so Short will not be enough in my opinion, this maybe depends on the part of used S7 device --> I wrote a ToDo for that in the code
   ![bildschirmfoto 2019-01-16 um 21 24 02](https://user-images.githubusercontent.com/43384429/51276568-579ac500-19d5-11e9-8ae9-dd43ef5a04f8.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services