You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by tf...@apache.org on 2020/06/30 19:00:33 UTC
[lucene-solr] 02/02: SOLR-14590: Don't close QParserPlugin in 8.x
This is an automated email from the ASF dual-hosted git repository.
tflobbe pushed a commit to branch branch_8x
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git
commit e927cb75f04a1ac1d182e6ea9a88bb122bb8d21a
Author: Tomas Fernandez Lobbe <tf...@apache.org>
AuthorDate: Tue Jun 30 11:59:58 2020 -0700
SOLR-14590: Don't close QParserPlugin in 8.x
It's not closeable
---
.../test/org/apache/solr/search/RankQParserPluginTest.java | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/solr/core/src/test/org/apache/solr/search/RankQParserPluginTest.java b/solr/core/src/test/org/apache/solr/search/RankQParserPluginTest.java
index 2e88ce2..9c255c9 100644
--- a/solr/core/src/test/org/apache/solr/search/RankQParserPluginTest.java
+++ b/solr/core/src/test/org/apache/solr/search/RankQParserPluginTest.java
@@ -54,11 +54,10 @@ public class RankQParserPluginTest extends SolrTestCaseJ4 {
}
public void testCreateParser() throws IOException {
- try (RankQParserPlugin rankQPPlugin = new RankQParserPlugin()) {
- QParser parser = rankQPPlugin.createParser("", new ModifiableSolrParams(), null, req());
- assertNotNull(parser);
- assertTrue(parser instanceof RankQParser);
- }
+ RankQParserPlugin rankQPPlugin = new RankQParserPlugin();
+ QParser parser = rankQPPlugin.createParser("", new ModifiableSolrParams(), null, req());
+ assertNotNull(parser);
+ assertTrue(parser instanceof RankQParser);
}
public void testSyntaxErrors() throws IOException, SyntaxError {
@@ -250,9 +249,8 @@ public class RankQParserPluginTest extends SolrTestCaseJ4 {
}
private RankQParser getRankQParser(SolrParams localParams, SolrParams params, SolrQueryRequest req) throws IOException {
- try (RankQParserPlugin rankQPPlugin = new RankQParserPlugin()) {
- return (RankQParser) rankQPPlugin.createParser("", localParams, params, req);
- }
+ RankQParserPlugin rankQPPlugin = new RankQParserPlugin();
+ return (RankQParser) rankQPPlugin.createParser("", localParams, params, req);
}
}