[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1231: MINIFICPP-1707 - Speed up linter

[GitBox <gi...@apache.org>]

szaszm commented on a change in pull request #1231:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1231#discussion_r778159685



##########
File path: thirdparty/google-styleguide/run_linter.py
##########
@@ -1,6 +1,10 @@
 import argparse
+import multiprocessing
 import os
 import cpplint
+from multiprocessing import Pool

Review comment:
       Only one of line 2 or line 5 should be enough.

##########
File path: cmake/Extensions.cmake
##########
@@ -115,7 +115,7 @@ macro(register_extension_linter target-name)
     get_property(extensions GLOBAL PROPERTY EXTENSION-LINTERS)
     set_property(GLOBAL APPEND PROPERTY EXTENSION-LINTERS "${target-name}")
     add_custom_target(${target-name}
-    COMMAND python ${CMAKE_SOURCE_DIR}/thirdparty/google-styleguide/run_linter.py -q -i ${CMAKE_CURRENT_LIST_DIR}/)
+    COMMAND python3 ${CMAKE_SOURCE_DIR}/thirdparty/google-styleguide/run_linter.py -q -i ${CMAKE_CURRENT_LIST_DIR}/)

Review comment:
       Is there a mainstream OS where `python` doesn't refer to python 3.x?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org