You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Darren Shepherd <da...@gmail.com> on 2013/09/19 00:17:14 UTC
Review Request 14218: Add spring lifecycle framework to handle modularization
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14218/
-----------------------------------------------------------
Review request for cloudstack, Alex Huang and Kelven Yang.
Repository: cloudstack-git
Description
-------
This maven project will handle all the extended lifecycle needed in Spring to find and register extensions in the their corresponding registries. This patch adds the project but it is not added to the main build.
Diffs
-----
framework/spring/lifecycle/pom.xml PRE-CREATION
framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/AbstractBeanCollector.java PRE-CREATION
framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/AbstractSmartLifeCycle.java PRE-CREATION
framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/CloudStackExtendedLifeCycle.java PRE-CREATION
framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/CloudStackExtendedLifeCycleStart.java PRE-CREATION
framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/CloudStackLog4jSetup.java PRE-CREATION
framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/ConfigDepotLifeCycle.java PRE-CREATION
framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/registry/DumpRegistry.java PRE-CREATION
framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/registry/ExtensionRegistry.java PRE-CREATION
framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/registry/RegistryLifecycle.java PRE-CREATION
Diff: https://reviews.apache.org/r/14218/diff/
Testing
-------
Thanks,
Darren Shepherd
Re: Review Request 14218: Add spring lifecycle framework to handle
modularization
Posted by Kelven Yang <ke...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14218/#review26518
-----------------------------------------------------------
Ship it!
Ship It!
- Kelven Yang
On Sept. 19, 2013, 9:41 p.m., Darren Shepherd wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14218/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2013, 9:41 p.m.)
>
>
> Review request for cloudstack, Alex Huang and Kelven Yang.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This maven project will handle all the extended lifecycle needed in Spring to find and register extensions in the their corresponding registries. This patch adds the project but it is not added to the main build.
>
>
> Diffs
> -----
>
> framework/spring/lifecycle/pom.xml PRE-CREATION
> framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/AbstractBeanCollector.java PRE-CREATION
> framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/AbstractSmartLifeCycle.java PRE-CREATION
> framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/CloudStackExtendedLifeCycle.java PRE-CREATION
> framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/CloudStackExtendedLifeCycleStart.java PRE-CREATION
> framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/CloudStackLog4jSetup.java PRE-CREATION
> framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/ConfigDepotLifeCycle.java PRE-CREATION
> framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/registry/DumpRegistry.java PRE-CREATION
> framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/registry/ExtensionRegistry.java PRE-CREATION
> framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/registry/RegistryLifecycle.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14218/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Darren Shepherd
>
>
Re: Review Request 14218: Add spring lifecycle framework to handle
modularization
Posted by Darren Shepherd <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14218/
-----------------------------------------------------------
(Updated Sept. 19, 2013, 9:41 p.m.)
Review request for cloudstack, Alex Huang and Kelven Yang.
Changes
-------
Last patch wasn't uploaded right
Repository: cloudstack-git
Description
-------
This maven project will handle all the extended lifecycle needed in Spring to find and register extensions in the their corresponding registries. This patch adds the project but it is not added to the main build.
Diffs (updated)
-----
framework/spring/lifecycle/pom.xml PRE-CREATION
framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/AbstractBeanCollector.java PRE-CREATION
framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/AbstractSmartLifeCycle.java PRE-CREATION
framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/CloudStackExtendedLifeCycle.java PRE-CREATION
framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/CloudStackExtendedLifeCycleStart.java PRE-CREATION
framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/CloudStackLog4jSetup.java PRE-CREATION
framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/ConfigDepotLifeCycle.java PRE-CREATION
framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/registry/DumpRegistry.java PRE-CREATION
framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/registry/ExtensionRegistry.java PRE-CREATION
framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/registry/RegistryLifecycle.java PRE-CREATION
Diff: https://reviews.apache.org/r/14218/diff/
Testing
-------
Thanks,
Darren Shepherd
Re: Review Request 14218: Add spring lifecycle framework to handle
modularization
Posted by Darren Shepherd <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14218/
-----------------------------------------------------------
(Updated Sept. 19, 2013, 9:31 p.m.)
Review request for cloudstack, Alex Huang and Kelven Yang.
Changes
-------
Compilation error in the patch
Repository: cloudstack-git
Description
-------
This maven project will handle all the extended lifecycle needed in Spring to find and register extensions in the their corresponding registries. This patch adds the project but it is not added to the main build.
Diffs (updated)
-----
framework/spring/lifecycle/pom.xml PRE-CREATION
framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/AbstractBeanCollector.java PRE-CREATION
framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/AbstractSmartLifeCycle.java PRE-CREATION
framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/CloudStackExtendedLifeCycle.java PRE-CREATION
framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/CloudStackExtendedLifeCycleStart.java PRE-CREATION
framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/CloudStackLog4jSetup.java PRE-CREATION
framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/ConfigDepotLifeCycle.java PRE-CREATION
framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/registry/DumpRegistry.java PRE-CREATION
framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/registry/ExtensionRegistry.java PRE-CREATION
framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/registry/RegistryLifecycle.java PRE-CREATION
Diff: https://reviews.apache.org/r/14218/diff/
Testing
-------
Thanks,
Darren Shepherd