You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/12/01 15:47:19 UTC
[GitHub] [camel-k] squakez opened a new issue, #3868: Automatically `make generate` every night
squakez opened a new issue, #3868:
URL: https://github.com/apache/camel-k/issues/3868
We can run a new task into the changelog workflow (and name it differently) to run a `make generate` every night and include any change in API, doc, whatever is regenerated automatically to avoid forgetting stuff or writing code that will be cleaned.
Ref #3818 #3867
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on issue #3868: Automatically `make generate` every night
Posted by GitBox <gi...@apache.org>.
tadayosi commented on issue #3868:
URL: https://github.com/apache/camel-k/issues/3868#issuecomment-1342193040
@squakez Good point. `resources.go` is generated every time we build so it seems to be possible to ignore it from git. I'm not sure if it's 100% ok to remove it from the repo, either, though.
A while ago I filed another idea to remove `resources.go` from the repo. `go:embed` is another way to embed resources in the code without need for regeneration each time.
* #3384
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on issue #3868: Automatically `make generate` every night
Posted by GitBox <gi...@apache.org>.
tadayosi commented on issue #3868:
URL: https://github.com/apache/camel-k/issues/3868#issuecomment-1334770574
Also let's not forget to run `make build` in the same workflow and update `pkg/resources/resources.go` nightly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez closed issue #3868: Automatically `make generate` every night
Posted by GitBox <gi...@apache.org>.
squakez closed issue #3868: Automatically `make generate` every night
URL: https://github.com/apache/camel-k/issues/3868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on issue #3868: Automatically `make generate` every night
Posted by GitBox <gi...@apache.org>.
squakez commented on issue #3868:
URL: https://github.com/apache/camel-k/issues/3868#issuecomment-1334896938
> Also let's not forget to run `make build` in the same workflow and update `pkg/resources/resources.go` nightly.
Thinking more carefully, do you think the resources.go should be at all something to refresh in the repo? after all, this is always regenerated, I'd be even inclined to `git ignore` it in order to reduce any possibility of conflict. However, I am not 100% sure of what could be a best practice with this kind of golang resource.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org