You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "Viraj Jasani (Jira)" <ji...@apache.org> on 2020/10/13 13:20:00 UTC
[jira] [Comment Edited] (PHOENIX-6124) Block adding/dropping a
column on a parent view for clients <4.15 and for clients that have
phoenix.allow.system.catalog.rollback=true
[ https://issues.apache.org/jira/browse/PHOENIX-6124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213107#comment-17213107 ]
Viraj Jasani edited comment on PHOENIX-6124 at 10/13/20, 1:19 PM:
------------------------------------------------------------------
Looks like due to space issue, test result was not saved as per precommit logs:
{code:java}
[2020-10-13T13:04:[2020-10-13T13:04:04.966Z] Recording test results
18:34:06 FATAL: Failed to save the JUnit test result
18:34:06 java.io.IOException: No space left on device
18:34:06 at sun.nio.ch.FileDispatcherImpl.write0(Native Method)
18:34:06 at sun.nio.ch.FileDispatcherImpl.write(FileDispatcherImpl.java:60)
{code}
was (Author: vjasani):
Looks like due to space issue, test result was not saved as per precommit logs:
[2020-10-13T13:04:[2020-10-13T13:04:04.966Z] Recording test results*18:34:06* FATAL: Failed to save the JUnit test result*18:34:06* java.io.IOException: No space left on device*18:34:06* at sun.nio.ch.FileDispatcherImpl.write0(Native Method)*18:34:06* at sun.nio.ch.FileDispatcherImpl.write(FileDispatcherImpl.java:60)
> Block adding/dropping a column on a parent view for clients <4.15 and for clients that have phoenix.allow.system.catalog.rollback=true
> --------------------------------------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-6124
> URL: https://issues.apache.org/jira/browse/PHOENIX-6124
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 5.0.0, 4.15.0
> Reporter: Chinmay Kulkarni
> Assignee: Viraj Jasani
> Priority: Blocker
> Fix For: 5.1.0, 4.16.0
>
>
> For pre-4.15 clients, we have to block adding/dropping a column to a table if it has child views since we can’t do any checkAndPut distributed locking (see [this|https://github.com/apache/phoenix/blob/6ecc66738e576a5349605c2f5b20003df03f95de/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java#L2595-L2616]).
> However, this is only prevented if the parent is a table and not if the parent is a view. We should extend [the condition|https://github.com/apache/phoenix/blob/6ecc66738e576a5349605c2f5b20003df03f95de/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java#L2591] to also cover views since conflicting mutations on its children can also lead to inconsistencies.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)