You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/01/14 00:56:44 UTC
[GitHub] KarmaGYZ commented on a change in pull request #7466:
[FLINK-11304][docs][table] Fix typo in time attributes doc
KarmaGYZ commented on a change in pull request #7466: [FLINK-11304][docs][table] Fix typo in time attributes doc
URL: https://github.com/apache/flink/pull/7466#discussion_r247371432
##########
File path: docs/dev/table/streaming/time_attributes.md
##########
@@ -317,9 +323,15 @@ class UserActionSource extends StreamTableSource[Row] with DefinedRowtimeAttribu
stream
}
- override def getRowtimeAttribute = {
+ override def getRowtimeAttributeDescriptors: util.List[RowtimeAttributeDescriptor] = {
// Mark the "UserActionTime" attribute as event-time attribute.
- "UserActionTime"
+ // here we create one attribute descriptor of "UserActionTime"
+ val rowtimeAttrDescr = new RowtimeAttributeDescriptor(
+ "UserActionTime",
Review comment:
@JaryZhen I still prefer to use tab. Besides, I think you should push this commit the master branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services