[GitHub] [pulsar-client-cpp] BewareMyPower commented on a diff in pull request #45: Stick clang-format version to 11 and add back docker-format.sh

[GitBox <gi...@apache.org>]

BewareMyPower commented on code in PR #45:
URL: https://github.com/apache/pulsar-client-cpp/pull/45#discussion_r1000302183


##########
README.md:
##########
@@ -222,6 +222,8 @@ cd tests
 
 ## Requirements for Contributors
 
-It's required to install [LLVM](https://llvm.org/builds/) for `clang-tidy` and `clang-format`. Pulsar C++ client use `clang-format` 6.0+ to format files.  `make format` automatically formats the files.
+It's required to install [LLVM](https://llvm.org/builds/) for `clang-tidy` and `clang-format`. Pulsar C++ client use `clang-format` **11** to format files.  `make format` automatically formats the files.
+
+For Ubuntu users, you can install `clang-format-11` via `apt install clang-format-11`. For other users, run `./docker-format.sh` if you have Docker installed.

Review Comment:
   @RobertIndie See here. Even if I am a Ubuntu user now, using `./docker-format.sh` could be faster now because I don't need to run `cmake`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org