You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2023/07/13 12:18:33 UTC

[GitHub] [pulsar] lhotari opened a new pull request, #20799: [fix][test] Fix resource leak in PulsarTestContext

lhotari opened a new pull request, #20799:
URL: https://github.com/apache/pulsar/pull/20799

   Fixes #20797
   
   ### Motivation
   
   See #20797. There's a resource leak in PulsarTestContext which was introduced in #19337 and #19376
   
   ### Modifications
   
   - use fields in super class to hold resources instead of having duplicates
   - all fields in PulsarService have protected setters due to `@Setter(AccessLevel.PROTECTED)`
     - this fact was missed in the original implementation of PulsarTestContext
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   ### Matching PR in forked repository
   
   PR in forked repository: <!-- ENTER URL HERE -->
   
   <!--
   After opening this PR, the build in apache/pulsar will fail and instructions will
   be provided for opening a PR in the PR author's forked repository.
   
   apache/pulsar pull requests should be first tested in your own fork since the 
   apache/pulsar CI based on GitHub Actions has constrained resources and quota.
   GitHub Actions provides separate quota for pull requests that are executed in 
   a forked repository.
   
   The tests will be run in the forked repository until all PR review comments have
   been handled, the tests pass and the PR is approved by a reviewer.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] lhotari merged pull request #20799: [fix][test] Fix resource leak in PulsarTestContext

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari merged PR #20799:
URL: https://github.com/apache/pulsar/pull/20799


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org