You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Dejan Bosanac (JIRA)" <ji...@apache.org> on 2012/08/30 12:39:07 UTC

[jira] [Created] (AMQ-4005) Implement pluggable broker lockers

Dejan Bosanac created AMQ-4005:
----------------------------------

             Summary: Implement pluggable broker lockers
                 Key: AMQ-4005
                 URL: https://issues.apache.org/jira/browse/AMQ-4005
             Project: ActiveMQ
          Issue Type: New Feature
    Affects Versions: 5.6.0
            Reporter: Dejan Bosanac
            Assignee: Dejan Bosanac
             Fix For: 5.7.0


Currently shared storage master/slave locking is a job of a persistence adapter.

It's hardcoded in KahaDB to use shared file locking, while JDBC allows at least some customization.

The idea is to create general locker interface and share it across available persistence adapters. So that for example, JDBC can use shared file lock or KahaDB use ZooKeeper lock when it's available.

We can also consider moving locking out of persistence layer and making it a job for a broker.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (AMQ-4005) Implement pluggable broker lockers

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AMQ-4005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446894#comment-13446894 ] 

Claus Ibsen commented on AMQ-4005:
----------------------------------

Seems like a few tests in activemq-core was affected
https://builds.apache.org/job/ActiveMQ/org.apache.activemq$activemq-core/1048/

I thought I accidentally broke something with my recent commits, but tracked it back to that changeset from the link above
                
> Implement pluggable broker lockers
> ----------------------------------
>
>                 Key: AMQ-4005
>                 URL: https://issues.apache.org/jira/browse/AMQ-4005
>             Project: ActiveMQ
>          Issue Type: New Feature
>    Affects Versions: 5.6.0
>            Reporter: Dejan Bosanac
>            Assignee: Dejan Bosanac
>             Fix For: 5.7.0
>
>
> Currently shared storage master/slave locking is a job of a persistence adapter.
> It's hardcoded in KahaDB to use shared file locking, while JDBC allows at least some customization.
> The idea is to create general locker interface and share it across available persistence adapters. So that for example, JDBC can use shared file lock or KahaDB use ZooKeeper lock when it's available.
> We can also consider moving locking out of persistence layer and making it a job for a broker.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (AMQ-4005) Implement pluggable broker lockers

Posted by "Dejan Bosanac (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AMQ-4005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448676#comment-13448676 ] 

Dejan Bosanac commented on AMQ-4005:
------------------------------------

This failure was not introduced by the change. It's a long-known issue. Gary created https://issues.apache.org/jira/browse/AMQ-4020 and https://issues.apache.org/jira/browse/AMQ-4021 to deal with it.
                
> Implement pluggable broker lockers
> ----------------------------------
>
>                 Key: AMQ-4005
>                 URL: https://issues.apache.org/jira/browse/AMQ-4005
>             Project: ActiveMQ
>          Issue Type: New Feature
>    Affects Versions: 5.6.0
>            Reporter: Dejan Bosanac
>            Assignee: Dejan Bosanac
>             Fix For: 5.7.0
>
>
> Currently shared storage master/slave locking is a job of a persistence adapter.
> It's hardcoded in KahaDB to use shared file locking, while JDBC allows at least some customization.
> The idea is to create general locker interface and share it across available persistence adapters. So that for example, JDBC can use shared file lock or KahaDB use ZooKeeper lock when it's available.
> We can also consider moving locking out of persistence layer and making it a job for a broker.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (AMQ-4005) Implement pluggable broker lockers

Posted by "Dejan Bosanac (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AMQ-4005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13454038#comment-13454038 ] 

Dejan Bosanac commented on AMQ-4005:
------------------------------------

Documentation is now available at https://cwiki.apache.org/confluence/display/ACTIVEMQ/Pluggable+storage+lockers
                
> Implement pluggable broker lockers
> ----------------------------------
>
>                 Key: AMQ-4005
>                 URL: https://issues.apache.org/jira/browse/AMQ-4005
>             Project: ActiveMQ
>          Issue Type: New Feature
>    Affects Versions: 5.6.0
>            Reporter: Dejan Bosanac
>            Assignee: Dejan Bosanac
>             Fix For: 5.7.0
>
>
> Currently shared storage master/slave locking is a job of a persistence adapter.
> It's hardcoded in KahaDB to use shared file locking, while JDBC allows at least some customization.
> The idea is to create general locker interface and share it across available persistence adapters. So that for example, JDBC can use shared file lock or KahaDB use ZooKeeper lock when it's available.
> We can also consider moving locking out of persistence layer and making it a job for a broker.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (AMQ-4005) Implement pluggable broker lockers

Posted by "Dejan Bosanac (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AMQ-4005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dejan Bosanac resolved AMQ-4005.
--------------------------------

    Resolution: Fixed

Fixed with svn revision 1383400.

Documentation is pending.
                
> Implement pluggable broker lockers
> ----------------------------------
>
>                 Key: AMQ-4005
>                 URL: https://issues.apache.org/jira/browse/AMQ-4005
>             Project: ActiveMQ
>          Issue Type: New Feature
>    Affects Versions: 5.6.0
>            Reporter: Dejan Bosanac
>            Assignee: Dejan Bosanac
>             Fix For: 5.7.0
>
>
> Currently shared storage master/slave locking is a job of a persistence adapter.
> It's hardcoded in KahaDB to use shared file locking, while JDBC allows at least some customization.
> The idea is to create general locker interface and share it across available persistence adapters. So that for example, JDBC can use shared file lock or KahaDB use ZooKeeper lock when it's available.
> We can also consider moving locking out of persistence layer and making it a job for a broker.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (AMQ-4005) Implement pluggable broker lockers

Posted by "Dejan Bosanac (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AMQ-4005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444862#comment-13444862 ] 

Dejan Bosanac commented on AMQ-4005:
------------------------------------

First step is donw with svn revision 1378881. New API is introduced and KahaDB/JDBC solutions were refactored to reflect it.
                
> Implement pluggable broker lockers
> ----------------------------------
>
>                 Key: AMQ-4005
>                 URL: https://issues.apache.org/jira/browse/AMQ-4005
>             Project: ActiveMQ
>          Issue Type: New Feature
>    Affects Versions: 5.6.0
>            Reporter: Dejan Bosanac
>            Assignee: Dejan Bosanac
>             Fix For: 5.7.0
>
>
> Currently shared storage master/slave locking is a job of a persistence adapter.
> It's hardcoded in KahaDB to use shared file locking, while JDBC allows at least some customization.
> The idea is to create general locker interface and share it across available persistence adapters. So that for example, JDBC can use shared file lock or KahaDB use ZooKeeper lock when it's available.
> We can also consider moving locking out of persistence layer and making it a job for a broker.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira