You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "irodriguez-nebustream (via GitHub)" <gi...@apache.org> on 2025/05/05 03:31:28 UTC

[PR] fix(embedded): handle SUPERSET_APP_ROOT in embedded dashboard URLs [superset]

irodriguez-nebustream opened a new pull request, #33356:
URL: https://github.com/apache/superset/pull/33356

   <!---
   Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   Here's the filled-out pull request description:
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   This PR adds support for `SUPERSET_APP_ROOT` subpath routing to the embedded dashboard SDK. When Superset is configured with a subpath (e.g., `SUPERSET_APP_ROOT="/charts"`), the embedded dashboard SDK now correctly constructs the iframe URL to include this path prefix.
   
   **Problem:**
   When embedding dashboards in applications where Superset is deployed with a subpath routing configuration, the SDK would attempt to load the dashboard at `/embedded/{id}` instead of the correct path `/charts/embedded/{id}`, resulting in 404 errors.
   
   **Solution:**
   - Added an optional `appRootPath` parameter to the `EmbedDashboardParams` type
   - Modified the `embedDashboard` function to include the application root path in the iframe source URL
   - Normalized the app root path to ensure consistent handling (removing trailing slashes)
   
   This change ensures the SDK produces iframe URLs that match Superset's routing configuration, eliminating 404 errors and making the embedded dashboard feature compatible with subpath deployments.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   N/A - This is an SDK fix that affects routing behavior
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   1. Configure a Superset instance with `SUPERSET_APP_ROOT="/charts"` in the config
   2. Use the updated SDK to embed a dashboard:
      ```typescript
      embedDashboard({
        id: "your-dashboard-id",
        supersetDomain: "http://localhost:8088",
        mountPoint: document.getElementById("dashboard-container"),
        fetchGuestToken: () => fetchGuestTokenFromYourBackend(),
        appRootPath: "/charts"  // Include this new parameter
      });
      ```
   3. Verify that:
      - The iframe loads successfully without 404 errors
      - The iframe source URL is constructed as `/charts/embedded/{id}`
      - The embedded dashboard renders correctly
      - API calls within the iframe (like `/charts/api/v1/me/roles/`) work properly
   
   ### ADDITIONAL INFORMATION
   - [x] Has associated issue: Fixes #XXXX (replace with actual issue number)
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration
   - [ ] Introduces new feature or API ✓ (adds optional `appRootPath` parameter to SDK)
   - [ ] Removes existing feature or API
   
   **Notes:**
   - This change is backward compatible - existing implementations without `appRootPath` will continue to work as before
   - The `appRootPath` parameter is optional and defaults to an empty string to maintain backward compatibility
   - Related to Superset's use of `process.env.SUPERSET_APP_ROOT` for subpath routing configuration
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(embedded): handle SUPERSET_APP_ROOT in embedded dashboard URLs [superset]

Posted by "Vitor-Avila (via GitHub)" <gi...@apache.org>.
Vitor-Avila commented on PR #33356:
URL: https://github.com/apache/superset/pull/33356#issuecomment-2854776105

   @irodriguez-nebustream I was also thinking about @morngaraf thoughts as well about the potential required changes to `EmbeddedApp` as well. But again, I don't have Superset running as a subpath so couldn't manually test it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(embedded): handle SUPERSET_APP_ROOT in embedded dashboard URLs [superset]

Posted by "irodriguez-nebustream (via GitHub)" <gi...@apache.org>.
irodriguez-nebustream commented on PR #33356:
URL: https://github.com/apache/superset/pull/33356#issuecomment-2852575502

   I notice this happen a few times on my builds too. I get that 429 as well `urllib.error.HTTPError: HTTP Error 429: Too Many Requests` 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(embedded): handle SUPERSET_APP_ROOT in embedded dashboard URLs [superset]

Posted by "korbit-ai[bot] (via GitHub)" <gi...@apache.org>.
korbit-ai[bot] commented on code in PR #33356:
URL: https://github.com/apache/superset/pull/33356#discussion_r2072809946


##########
superset-frontend/src/embedded/index.tsx:
##########
@@ -41,6 +41,7 @@ setupPlugins();
 
 const debugMode = process.env.WEBPACK_MODE === 'development';
 const bootstrapData = getBootstrapData();
+const appRootPath = process.env.SUPERSET_APP_ROOT || '';

Review Comment:
   ### Unclear Default Value Intent <sub>![category Readability](https://img.shields.io/badge/Readability-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   Using empty string as a fallback for SUPERSET_APP_ROOT lacks clarity about the default behavior.
   
   ###### Why this matters
   Without explicit default value documentation, future developers may not understand why an empty string was chosen as the fallback and what impact it has on URL construction.
   
   ###### Suggested change ∙ *Feature Preview*
   ```typescript
   // Default to empty string for root path when SUPERSET_APP_ROOT is not set
   const appRootPath = process.env.SUPERSET_APP_ROOT || '';
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/c74e98ed-8deb-4f20-bcfc-f8847124136a/upvote) [![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/c74e98ed-8deb-4f20-bcfc-f8847124136a?what_not_true=true)  [![Not in Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/c74e98ed-8deb-4f20-bcfc-f8847124136a?what_out_of_scope=true) [![Not in coding standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/c74e98ed-8deb-4f20-bcfc-f8847124136a?what_not_in_standard=true) [![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/c74e98ed-8deb-4f20-bcfc-f8847124136a)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:2baaa577-4bc0-4480-97c4-d903d1ae0fb6 -->
   
   
   [](2baaa577-4bc0-4480-97c4-d903d1ae0fb6)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(embedded): handle SUPERSET_APP_ROOT in embedded dashboard URLs [superset]

Posted by "irodriguez-nebustream (via GitHub)" <gi...@apache.org>.
irodriguez-nebustream commented on PR #33356:
URL: https://github.com/apache/superset/pull/33356#issuecomment-2860498688

   @rusackas I think everything passed. Except for that skipped check.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(embedded): handle SUPERSET_APP_ROOT in embedded dashboard URLs [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #33356:
URL: https://github.com/apache/superset/pull/33356#issuecomment-2867356034

   Approving CI to run again 🤞 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(embedded): handle SUPERSET_APP_ROOT in embedded dashboard URLs [superset]

Posted by "irodriguez-nebustream (via GitHub)" <gi...@apache.org>.
irodriguez-nebustream commented on code in PR #33356:
URL: https://github.com/apache/superset/pull/33356#discussion_r2080680713


##########
superset-frontend/src/embedded/index.tsx:
##########
@@ -156,7 +157,7 @@ function guestUnauthorizedHandler() {
 function start() {
   const getMeWithRole = makeApi<void, { result: UserWithPermissionsAndRoles }>({
     method: 'GET',
-    endpoint: '/api/v1/me/roles/',
+    endpoint: `${appRootPath}/api/v1/me/roles/`,

Review Comment:
   I updated the code with the changes. Everything works as expected.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(embedded): handle SUPERSET_APP_ROOT in embedded dashboard URLs [superset]

Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on code in PR #33356:
URL: https://github.com/apache/superset/pull/33356#discussion_r2078713319


##########
superset-frontend/src/embedded/index.tsx:
##########
@@ -41,6 +41,7 @@ setupPlugins();
 
 const debugMode = process.env.WEBPACK_MODE === 'development';
 const bootstrapData = getBootstrapData();
+const appRootPath = process.env.SUPERSET_APP_ROOT || '';

Review Comment:
   mmmh, wondering why we go through `process.env` here, seems we should only use `applicationRoot()` ideally always outside of module scope...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(embedded): handle SUPERSET_APP_ROOT in embedded dashboard URLs [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #33356:
URL: https://github.com/apache/superset/pull/33356#issuecomment-2860406302

   running CI... ping me if it looks good 🤞 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(embedded): handle SUPERSET_APP_ROOT in embedded dashboard URLs [superset]

Posted by "morngaraf (via GitHub)" <gi...@apache.org>.
morngaraf commented on PR #33356:
URL: https://github.com/apache/superset/pull/33356#issuecomment-2854736168

   @irodriguez-nebustream 
   Thank you for opening a PR to fix the issue. I noticed it as well, but ended up monkey patching during deployment on my side for the time-being.
   
   In my first attempt I tried to replace only `/api/v1/me/roles/` with the expected path, but it was not enough: React routes, e.g. `<Route path="/embedded/:uuid/" component={EmbeddedRoute} />`, are also broken. When I "fixed" the routes, dashboard started loading, but all API calls the dashboard itself is making (like `/api/v1/dashboard` etc.) were still using the wrong path.
   
   I suspect that the following changes have to be done to fix all of the above:
   ```ts
   import getBootstrapData, { applicationRoot } from 'src/utils/getBootstrapData';
   
   ...
   
   const EmbeddedApp = () => (
     <Router basename={applicationRoot()}>
       {/* todo (embedded) remove this line after uuids are deployed */}
       <Route path="/dashboard/:idOrSlug/embedded/" component={EmbeddedRoute} />
       <Route path="/embedded/:uuid/" component={EmbeddedRoute} />
     </Router>
   );
   
   ...
   
   function setupGuestClient(guestToken: string) {
     setupClient({
       appRoot: applicationRoot(),
       guestToken,
       guestTokenHeaderName: bootstrapData.config?.GUEST_TOKEN_HEADER_NAME,
       unauthorizedHandler: guestUnauthorizedHandler,
     });
   }
   ```
   
   
   `<Router basename={applicationRoot()}>` is taken from `App.tsx`, 
   `setupClient({ appRoot: applicationRoot() });` is used in `preamble.ts`.
   
   Since `makeApi` by default uses singleton of `SupersetClient`, which is configured by `setupClient`, we should not have to modify the actual '/api/v1/me/roles/' endpoint with these changes, and all other "broken" api calls should also be fixed automatically.
   
   Anyways, these are simply my guesses and I'm quite new to Superset. Maybe later this month I or one of my colleagues will have time to verify the theories locally, and we would be happy to help moving this forward.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(embedded): handle SUPERSET_APP_ROOT in embedded dashboard URLs [superset]

Posted by "Vitor-Avila (via GitHub)" <gi...@apache.org>.
Vitor-Avila commented on PR #33356:
URL: https://github.com/apache/superset/pull/33356#issuecomment-2854766962

   @rusackas I noticed you added me as a reviewer here. I can def do manual testing to make sure these code changes don't impact the standard (without `SUPERSET_APP_ROOT` configured) flow. 
   
   I don't currently have a Superset instance running with `SUPERSET_APP_ROOT` configured to test if this would solve for that, tho. Do we have clear docs on how to setup Superset that way? happy to help testing but would need some guidance on that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(embedded): handle SUPERSET_APP_ROOT in embedded dashboard URLs [superset]

Posted by "irodriguez-nebustream (via GitHub)" <gi...@apache.org>.
irodriguez-nebustream commented on PR #33356:
URL: https://github.com/apache/superset/pull/33356#issuecomment-2855426242

   @Vitor-Avila @rusackas Let me try implementing the other things that @morngaraf mentioned. I think its worth looking into and I can thoroughly test locally. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(embedded): handle SUPERSET_APP_ROOT in embedded dashboard URLs [superset]

Posted by "irodriguez-nebustream (via GitHub)" <gi...@apache.org>.
irodriguez-nebustream commented on PR #33356:
URL: https://github.com/apache/superset/pull/33356#issuecomment-2864798560

   @mistercrunch @rusackas I went ahead an updated the code to match what the comments and suggested changes that were mentioned. I verified the changes locally and everything works the same. Attached a new screenshot 
   ![image](https://github.com/user-attachments/assets/dc9ac6a2-a8c0-44c9-b0d3-0055b13cea29)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(embedded): handle SUPERSET_APP_ROOT in embedded dashboard URLs [superset]

Posted by "morngaraf (via GitHub)" <gi...@apache.org>.
morngaraf commented on code in PR #33356:
URL: https://github.com/apache/superset/pull/33356#discussion_r2079198351


##########
superset-frontend/src/embedded/index.tsx:
##########
@@ -156,7 +157,7 @@ function guestUnauthorizedHandler() {
 function start() {
   const getMeWithRole = makeApi<void, { result: UserWithPermissionsAndRoles }>({
     method: 'GET',
-    endpoint: '/api/v1/me/roles/',
+    endpoint: `${appRootPath}/api/v1/me/roles/`,

Review Comment:
   i think we should leave the original `'/api/v1/me/roles/'` endpoint value here:
   now with `appRoot` being passed to `setupClient` this `makeApi` call should work properly without explicit app root path in the endpoint.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(embedded): handle SUPERSET_APP_ROOT in embedded dashboard URLs [superset]

Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch merged PR #33356:
URL: https://github.com/apache/superset/pull/33356


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(embedded): handle SUPERSET_APP_ROOT in embedded dashboard URLs [superset]

Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on code in PR #33356:
URL: https://github.com/apache/superset/pull/33356#discussion_r2078713567


##########
superset-frontend/src/embedded/index.tsx:
##########
@@ -156,7 +157,7 @@ function guestUnauthorizedHandler() {
 function start() {
   const getMeWithRole = makeApi<void, { result: UserWithPermissionsAndRoles }>({
     method: 'GET',
-    endpoint: '/api/v1/me/roles/',
+    endpoint: `${appRootPath}/api/v1/me/roles/`,

Review Comment:
   why not `applicationRoot()` here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(embedded): handle SUPERSET_APP_ROOT in embedded dashboard URLs [superset]

Posted by "irodriguez-nebustream (via GitHub)" <gi...@apache.org>.
irodriguez-nebustream commented on code in PR #33356:
URL: https://github.com/apache/superset/pull/33356#discussion_r2080680883


##########
superset-frontend/src/embedded/index.tsx:
##########
@@ -41,6 +41,7 @@ setupPlugins();
 
 const debugMode = process.env.WEBPACK_MODE === 'development';
 const bootstrapData = getBootstrapData();
+const appRootPath = process.env.SUPERSET_APP_ROOT || '';

Review Comment:
   Agreed, this was not needed. I made the changes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(embedded): handle SUPERSET_APP_ROOT in embedded dashboard URLs [superset]

Posted by "irodriguez-nebustream (via GitHub)" <gi...@apache.org>.
irodriguez-nebustream commented on PR #33356:
URL: https://github.com/apache/superset/pull/33356#issuecomment-2856404819

   ![image](https://github.com/user-attachments/assets/8ba7bd3a-fdf4-4f1d-845e-e480709a88b9)
   Okay, I can 100% confirm that the changes  that @morngaraf mentioned worked locally. I was able to get the embedded section working and I built the image, tagged it locally then spun up a container and called it from my webapp. I can add a screenshot of the network call if that helps. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(embedded): handle SUPERSET_APP_ROOT in embedded dashboard URLs [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #33356:
URL: https://github.com/apache/superset/pull/33356#issuecomment-2855381789

   I think this will need a rebase to get the CI to pass (it's stuck on a docker fix that was contributed after this PR opened).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org