You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/07/15 00:42:04 UTC
[jira] [Commented] (DRILL-3497) Throw UserException#validationError
for errors when modifying options
[ https://issues.apache.org/jira/browse/DRILL-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14627197#comment-14627197 ]
ASF GitHub Bot commented on DRILL-3497:
---------------------------------------
GitHub user sudheeshkatkam opened a pull request:
https://github.com/apache/drill/pull/91
DRILL-3497: Throw UserException#validationError for errors when modifying options
Rebased on top of DRILL-2304.
@jaltekruse please review the third commit: 6ec7b32
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sudheeshkatkam/drill DRILL-3497
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/91.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #91
----
commit 313c8e3632fa71a5ed5f62baf1146e8c20f80065
Author: Sudheesh Katkam <sk...@maprtech.com>
Date: 2015-07-14T18:29:56Z
DRILL-2304: Part 1: Documentation for OptionManagers
+ corrected error message in BaseOptionManager
+ use getAdmin in setOption method
commit f33654c7c539863e56958cc1746eded329b73e61
Author: Sudheesh Katkam <sk...@maprtech.com>
Date: 2015-07-14T21:54:16Z
DRILL-2304: Part 2: Manage options with lowercase names
commit 6ec7b326459094a865846b1758e9d4457752af4c
Author: Sudheesh Katkam <sk...@maprtech.com>
Date: 2015-07-14T22:33:30Z
DRILL-3497: Throw UserException#validationError instead of SetOptionException and ExpressionParsingException for options
+ Fixed bug in PositiveLongValidator (0 is not positive)
----
> Throw UserException#validationError for errors when modifying options
> ---------------------------------------------------------------------
>
> Key: DRILL-3497
> URL: https://issues.apache.org/jira/browse/DRILL-3497
> Project: Apache Drill
> Issue Type: Bug
> Components: Execution - Flow
> Reporter: Sudheesh Katkam
> Assignee: Sudheesh Katkam
> Priority: Minor
> Fix For: 1.2.0
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)