You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/10/04 18:02:33 UTC
[kudu-CR] [clock] update description of --time source flag
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14374
Change subject: [clock] update description of --time_source flag
......................................................................
[clock] update description of --time_source flag
Update the description of the --time_source flag. In prior version it
might read as to be a test-only flag. Other minor modifications.
This patch does not contain any functional modifications.
Change-Id: I5a684fd3373724e09247106d35a23c225d16f366
---
M src/kudu/clock/hybrid_clock.cc
1 file changed, 8 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/14374/1
--
To view, visit http://gerrit.cloudera.org:8080/14374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5a684fd3373724e09247106d35a23c225d16f366
Gerrit-Change-Number: 14374
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [clock] update description of --time source flag
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14374 )
Change subject: [clock] update description of --time_source flag
......................................................................
[clock] update description of --time_source flag
Update the description of the --time_source flag. In prior version it
might read as to be a test-only flag. Other minor modifications.
This patch does not contain any functional modifications.
Change-Id: I5a684fd3373724e09247106d35a23c225d16f366
Reviewed-on: http://gerrit.cloudera.org:8080/14374
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/clock/hybrid_clock.cc
1 file changed, 8 insertions(+), 7 deletions(-)
Approvals:
Grant Henke: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5a684fd3373724e09247106d35a23c225d16f366
Gerrit-Change-Number: 14374
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [clock] update description of --time source flag
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14374 )
Change subject: [clock] update description of --time_source flag
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14374/1/src/kudu/clock/hybrid_clock.cc
File src/kudu/clock/hybrid_clock.cc:
http://gerrit.cloudera.org:8080/#/c/14374/1/src/kudu/clock/hybrid_clock.cc@65
PS1, Line 65: "'system', 'builtin', or 'mock' (the latter is for tests only)");
> Maybe instead of "the latter" be explicit and say "(mock is for tests only)
Done
--
To view, visit http://gerrit.cloudera.org:8080/14374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a684fd3373724e09247106d35a23c225d16f366
Gerrit-Change-Number: 14374
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 04 Oct 2019 18:45:34 +0000
Gerrit-HasComments: Yes
[kudu-CR] [clock] update description of --time source flag
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14374 )
Change subject: [clock] update description of --time_source flag
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14374/1/src/kudu/clock/hybrid_clock.cc
File src/kudu/clock/hybrid_clock.cc:
http://gerrit.cloudera.org:8080/#/c/14374/1/src/kudu/clock/hybrid_clock.cc@65
PS1, Line 65: "'system', 'builtin', or 'mock' (the latter is for tests only)");
Maybe instead of "the latter" be explicit and say "(mock is for tests only).
--
To view, visit http://gerrit.cloudera.org:8080/14374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a684fd3373724e09247106d35a23c225d16f366
Gerrit-Change-Number: 14374
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 04 Oct 2019 18:21:55 +0000
Gerrit-HasComments: Yes
[kudu-CR] [clock] update description of --time source flag
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14374 )
Change subject: [clock] update description of --time_source flag
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a684fd3373724e09247106d35a23c225d16f366
Gerrit-Change-Number: 14374
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 04 Oct 2019 18:51:09 +0000
Gerrit-HasComments: No
[kudu-CR] [clock] update description of --time source flag
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14374
to look at the new patch set (#2).
Change subject: [clock] update description of --time_source flag
......................................................................
[clock] update description of --time_source flag
Update the description of the --time_source flag. In prior version it
might read as to be a test-only flag. Other minor modifications.
This patch does not contain any functional modifications.
Change-Id: I5a684fd3373724e09247106d35a23c225d16f366
---
M src/kudu/clock/hybrid_clock.cc
1 file changed, 8 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/14374/2
--
To view, visit http://gerrit.cloudera.org:8080/14374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5a684fd3373724e09247106d35a23c225d16f366
Gerrit-Change-Number: 14374
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)