You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2017/07/05 09:15:38 UTC

Review Request 60647: Fixed the mention of default ports in 'configuration.md'.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60647/
-----------------------------------------------------------

Review request for mesos, Andrei Budnik and Benjamin Bannier.


Repository: mesos


Description
-------

See summary.


Diffs
-----

  docs/configuration.md 007d0f556375f331148c9ad09be8b301ab31a01c 


Diff: https://reviews.apache.org/r/60647/diff/1/


Testing
-------

make check


Thanks,

Jan Schlicht


Re: Review Request 60647: Fixed the mention of default ports in 'configuration.md'.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60647/#review179647
-----------------------------------------------------------


Ship it!




Ship It!

- Gilbert Song


On July 5, 2017, 2:15 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60647/
> -----------------------------------------------------------
> 
> (Updated July 5, 2017, 2:15 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 007d0f556375f331148c9ad09be8b301ab31a01c 
> 
> 
> Diff: https://reviews.apache.org/r/60647/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Re: Review Request 60647: Fixed the mention of default ports in 'configuration.md'.

Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60647/#review179649
-----------------------------------------------------------


Ship it!




Ship It!

- Gastón Kleiman


On July 5, 2017, 9:15 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60647/
> -----------------------------------------------------------
> 
> (Updated July 5, 2017, 9:15 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 007d0f556375f331148c9ad09be8b301ab31a01c 
> 
> 
> Diff: https://reviews.apache.org/r/60647/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Re: Review Request 60647: Fixed the mention of default ports in 'configuration.md'.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60647/#review183843
-----------------------------------------------------------


Ship it!




Ship It!

- Alexander Rukletsov


On July 5, 2017, 9:15 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60647/
> -----------------------------------------------------------
> 
> (Updated July 5, 2017, 9:15 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 007d0f556375f331148c9ad09be8b301ab31a01c 
> 
> 
> Diff: https://reviews.apache.org/r/60647/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Re: Review Request 60647: Fixed the mention of default ports in 'configuration.md'.

Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60647/#review179613
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Bannier


On July 5, 2017, 11:15 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60647/
> -----------------------------------------------------------
> 
> (Updated July 5, 2017, 11:15 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 007d0f556375f331148c9ad09be8b301ab31a01c 
> 
> 
> Diff: https://reviews.apache.org/r/60647/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Re: Review Request 60647: Fixed the mention of default ports in 'configuration.md'.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60647/#review179732
-----------------------------------------------------------



Bad patch!

Reviews applied: [60647]

Failed command: python support/apply-reviews.py -n -r 60647

Error:
Traceback (most recent call last):
  File "support/apply-reviews.py", line 417, in <module>
    main()
  File "support/apply-reviews.py", line 412, in main
    reviewboard(options)
  File "support/apply-reviews.py", line 402, in reviewboard
    apply_review(options)
  File "support/apply-reviews.py", line 158, in apply_review
    fetch_patch(options)
  File "support/apply-reviews.py", line 215, in fetch_patch
    shell(cmd, options['dry_run'])
UnboundLocalError: local variable 'cmd' referenced before assignment

Full log: http://mesos-winbot.westus.cloudapp.azure.com/logs/125/console

- Mesos Reviewbot Windows


On July 5, 2017, 9:15 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60647/
> -----------------------------------------------------------
> 
> (Updated July 5, 2017, 9:15 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 007d0f556375f331148c9ad09be8b301ab31a01c 
> 
> 
> Diff: https://reviews.apache.org/r/60647/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>