[jira] [Resolved] (TOBAGO-1453) SelectManyRendererBase should support Collection

["Volker Weber (JIRA)" <de...@myfaces.apache.org>]

     [ https://issues.apache.org/jira/browse/TOBAGO-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Volker Weber resolved TOBAGO-1453.
----------------------------------
    Resolution: Fixed

The jsf 1.0 code copied from SharedRendererUtils nearly 9 years ago was updated to current 2.2.8 version.

> SelectManyRendererBase should support Collection
> ------------------------------------------------
>
>                 Key: TOBAGO-1453
>                 URL: https://issues.apache.org/jira/browse/TOBAGO-1453
>             Project: MyFaces Tobago
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.7
>            Reporter: Dennis Kieselhorst
>            Assignee: Volker Weber
>             Fix For: 2.0.8
>
>
> Currently an IllegalArgumentException is thrown when trying to use selectMany with Collection.
> There is a code comment that UISelectMany expects List but this is no longer valid: https://docs.oracle.com/javaee/6/api/javax/faces/component/UISelectMany.html
> {noformat}
> Caused by: java.lang.IllegalArgumentException: ValueBinding for UISelectMany must be of type List or Array
> 	at org.apache.myfaces.tobago.renderkit.SelectManyRendererBase.getConvertedUISelectManyValue(SelectManyRendererBase.java:182)
> 	at org.apache.myfaces.tobago.renderkit.SelectManyRendererBase.getConvertedValue(SelectManyRendererBase.java:88)
> 	at org.apache.myfaces.tobago.renderkit.AbstractRendererBaseWrapper.getConvertedValue(AbstractRendererBaseWrapper.java:90)
> 	at javax.faces.component.UISelectMany.getConvertedValue(UISelectMany.java:388)
> 	at javax.faces.component.UIInput.validate(UIInput.java:598)
> 	at javax.faces.component.UIInput.processValidators(UIInput.java:274)
> 	at javax.faces.component.UIComponentBase.processValidators(UIComponentBase.java:1457)
> 	at org.apache.myfaces.tobago.internal.component.AbstractUIBox.processValidators(AbstractUIBox.java:38)
> 	at javax.faces.component.UIComponentBase.processValidators(UIComponentBase.java:1457)
> 	at javax.faces.component.UIComponentBase.processValidators(UIComponentBase.java:1457)
> 	at org.apache.myfaces.tobago.internal.component.AbstractUIForm.processValidators(AbstractUIForm.java:83)
> 	at org.apache.myfaces.tobago.internal.component.AbstractUIPage.processValidators(AbstractUIPage.java:214)
> 	at javax.faces.component.UIComponentBase.processValidators(UIComponentBase.java:1457)
> 	at javax.faces.component.UIViewRoot._processValidatorsDefault(UIViewRoot.java:1697)
> 	at javax.faces.component.UIViewRoot.access$600(UIViewRoot.java:77)
> 	at javax.faces.component.UIViewRoot$ProcessValidatorPhaseProcessor.process(UIViewRoot.java:1804)
> 	at javax.faces.component.UIViewRoot._process(UIViewRoot.java:1653)
> 	at javax.faces.component.UIViewRoot.processValidators(UIViewRoot.java:909)
> 	at org.apache.myfaces.lifecycle.ProcessValidationsExecutor.execute(ProcessValidationsExecutor.java:38)
> 	at org.apache.myfaces.lifecycle.LifecycleImpl.executePhase(LifecycleImpl.java:196)
> 	at org.apache.myfaces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:143)
> 	at javax.faces.webapp.FacesServlet.service(FacesServlet.java:198)
> 	... 63 more
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)