You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2012/07/09 21:20:03 UTC
Review Request: Fixed a memory leak in process::collect.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5845/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Description
-------
A memory leak is possible in process::collect if the timeout is none and some of the futures return failure.
Diffs
-----
third_party/libprocess/include/process/collect.hpp 7e3467f
Diff: https://reviews.apache.org/r/5845/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request: Fixed two bugs (a memory leak and a race condition) in
process::collect.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5845/#review9184
-----------------------------------------------------------
Ship it!
third_party/libprocess/include/process/collect.hpp
<https://reviews.apache.org/r/5845/#comment19660>
why do u need to copy the future and return it here? is promise being deleted inside the CollectProcess?
- Vinod Kone
On July 10, 2012, 6:45 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5845/
> -----------------------------------------------------------
>
> (Updated July 10, 2012, 6:45 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> A memory leak is possible in process::collect if the timeout is none and some of the futures return failure.
>
>
> Diffs
> -----
>
> third_party/libprocess/include/process/collect.hpp 7e3467f
>
> Diff: https://reviews.apache.org/r/5845/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request: Fixed two bugs (a memory leak and a race condition) in
process::collect.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5845/#review9309
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On July 10, 2012, 6:45 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5845/
> -----------------------------------------------------------
>
> (Updated July 10, 2012, 6:45 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> A memory leak is possible in process::collect if the timeout is none and some of the futures return failure.
>
>
> Diffs
> -----
>
> third_party/libprocess/include/process/collect.hpp 7e3467f
>
> Diff: https://reviews.apache.org/r/5845/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request: Fixed two bugs (a memory leak and a race condition) in
process::collect.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5845/
-----------------------------------------------------------
(Updated July 10, 2012, 6:45 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Fixed the race condition.
Summary (updated)
-----------------
Fixed two bugs (a memory leak and a race condition) in process::collect.
Description
-------
A memory leak is possible in process::collect if the timeout is none and some of the futures return failure.
Diffs (updated)
-----
third_party/libprocess/include/process/collect.hpp 7e3467f
Diff: https://reviews.apache.org/r/5845/diff/
Testing
-------
make check
Thanks,
Jie Yu