You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Jon Weygandt (JIRA)" <ji...@apache.org> on 2009/10/01 00:15:23 UTC
[jira] Created: (SHINDIG-1183) Unsupported features are not handled
properly
Unsupported features are not handled properly
---------------------------------------------
Key: SHINDIG-1183
URL: https://issues.apache.org/jira/browse/SHINDIG-1183
Project: Shindig
Issue Type: Bug
Components: Java
Affects Versions: 1.1-BETA3
Reporter: Jon Weygandt
Priority: Minor
Per spec section 3.1.3, 5a: http://www.opensocial.org/Technical-Resources/opensocial-spec-v09/Gadgets-API-Specification.html#process unsupported features MUST emit an error message. There are 2 bugs.
Bug 1: Inside of GadgetFeatureRegistry there is a cache based on requested features. However the getFeatures may be called from the JS servlet or the render servlet. For the JS servlet, the unsupported features are silently ignored, but result in a cache entry. Then when called for rendering, the cache entry is found, resulting in NO error message happening. This fix took the approach of having 2 different caches based upon the presence of the unsupported collection argument. GadgetFeatureRegistryTest was modified accordingly along with 3 new tests to complete the 2x2 test matrix (called in context of JS servlet or render servlet) x (with and without unsupported features).
Bug 2: To ensure the error message gets back to the end user, rather than logged only server side, RenderingGadgetRewriter needed to throw a RewritingException rather than a RuntimeException. Additionally, our implementation uses Guice to enhance this implementation, so a number of private members have been made protected to enhance code reuse. Along with the changes, the RenderingGadgetRewriterTest was updated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-1183) Unsupported features are not
handled properly
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773924#action_12773924 ]
Paul Lindner commented on SHINDIG-1183:
---------------------------------------
did John's recent changes cover this issue? I think it may.. I see UnsupportedFeatureExceptions being thrown..
> Unsupported features are not handled properly
> ---------------------------------------------
>
> Key: SHINDIG-1183
> URL: https://issues.apache.org/jira/browse/SHINDIG-1183
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 1.1-BETA3
> Reporter: Jon Weygandt
> Priority: Minor
> Attachments: fix-1183-bug.patch
>
>
> Per spec section 3.1.3, 5a: http://www.opensocial.org/Technical-Resources/opensocial-spec-v09/Gadgets-API-Specification.html#process unsupported features MUST emit an error message. There are 2 bugs.
> Bug 1: Inside of GadgetFeatureRegistry there is a cache based on requested features. However the getFeatures may be called from the JS servlet or the render servlet. For the JS servlet, the unsupported features are silently ignored, but result in a cache entry. Then when called for rendering, the cache entry is found, resulting in NO error message happening. This fix took the approach of having 2 different caches based upon the presence of the unsupported collection argument. GadgetFeatureRegistryTest was modified accordingly along with 3 new tests to complete the 2x2 test matrix (called in context of JS servlet or render servlet) x (with and without unsupported features).
> Bug 2: To ensure the error message gets back to the end user, rather than logged only server side, RenderingGadgetRewriter needed to throw a RewritingException rather than a RuntimeException. Additionally, our implementation uses Guice to enhance this implementation, so a number of private members have been made protected to enhance code reuse. Along with the changes, the RenderingGadgetRewriterTest was updated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-1183) Unsupported features are not
handled properly
Posted by "Jon Weygandt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jon Weygandt resolved SHINDIG-1183.
-----------------------------------
Resolution: Duplicate
Incorporated into patch: http://codereview.appspot.com/143046/show
> Unsupported features are not handled properly
> ---------------------------------------------
>
> Key: SHINDIG-1183
> URL: https://issues.apache.org/jira/browse/SHINDIG-1183
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 1.1-BETA3
> Reporter: Jon Weygandt
> Priority: Minor
> Attachments: fix-1183-bug.patch
>
>
> Per spec section 3.1.3, 5a: http://www.opensocial.org/Technical-Resources/opensocial-spec-v09/Gadgets-API-Specification.html#process unsupported features MUST emit an error message. There are 2 bugs.
> Bug 1: Inside of GadgetFeatureRegistry there is a cache based on requested features. However the getFeatures may be called from the JS servlet or the render servlet. For the JS servlet, the unsupported features are silently ignored, but result in a cache entry. Then when called for rendering, the cache entry is found, resulting in NO error message happening. This fix took the approach of having 2 different caches based upon the presence of the unsupported collection argument. GadgetFeatureRegistryTest was modified accordingly along with 3 new tests to complete the 2x2 test matrix (called in context of JS servlet or render servlet) x (with and without unsupported features).
> Bug 2: To ensure the error message gets back to the end user, rather than logged only server side, RenderingGadgetRewriter needed to throw a RewritingException rather than a RuntimeException. Additionally, our implementation uses Guice to enhance this implementation, so a number of private members have been made protected to enhance code reuse. Along with the changes, the RenderingGadgetRewriterTest was updated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-1183) Unsupported features are not handled
properly
Posted by "Jon Weygandt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jon Weygandt updated SHINDIG-1183:
----------------------------------
Attachment: fix-1183-bug.patch
> Unsupported features are not handled properly
> ---------------------------------------------
>
> Key: SHINDIG-1183
> URL: https://issues.apache.org/jira/browse/SHINDIG-1183
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 1.1-BETA3
> Reporter: Jon Weygandt
> Priority: Minor
> Attachments: fix-1183-bug.patch
>
>
> Per spec section 3.1.3, 5a: http://www.opensocial.org/Technical-Resources/opensocial-spec-v09/Gadgets-API-Specification.html#process unsupported features MUST emit an error message. There are 2 bugs.
> Bug 1: Inside of GadgetFeatureRegistry there is a cache based on requested features. However the getFeatures may be called from the JS servlet or the render servlet. For the JS servlet, the unsupported features are silently ignored, but result in a cache entry. Then when called for rendering, the cache entry is found, resulting in NO error message happening. This fix took the approach of having 2 different caches based upon the presence of the unsupported collection argument. GadgetFeatureRegistryTest was modified accordingly along with 3 new tests to complete the 2x2 test matrix (called in context of JS servlet or render servlet) x (with and without unsupported features).
> Bug 2: To ensure the error message gets back to the end user, rather than logged only server side, RenderingGadgetRewriter needed to throw a RewritingException rather than a RuntimeException. Additionally, our implementation uses Guice to enhance this implementation, so a number of private members have been made protected to enhance code reuse. Along with the changes, the RenderingGadgetRewriterTest was updated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.