[GitHub] [iceberg] stevenzwu commented on a change in pull request #3001: Flink: add monitoring metrics to Flink Iceberg sink

[GitBox <gi...@apache.org>]

stevenzwu commented on a change in pull request #3001:
URL: https://github.com/apache/iceberg/pull/3001#discussion_r701554902



##########
File path: flink/src/main/java/org/apache/iceberg/flink/sink/FlinkSink.java
##########
@@ -249,6 +251,21 @@ public Builder uidPrefix(String newPrefix) {
       return this;
     }
 
+    /**
+     * Set the {@link SlidingWindowReservoir} size (number of measurements stored)
+     * for the two histogram metrics of data files and delete file size distribution.
+     *
+     * @param newReservoirSize the new histogram reservoir size for the file size distribution.
+     * default reservoir size is 128, which only add a small memory overhead of 1 KB (128 x 8B) per histogram.
+     * For use cases with a lot of files, a larger reservoir size can produce more accurate histogram distribution.
+     */
+    public Builder fileSizeHistogramReservoirSize(int newReservoirSize) {

Review comment:
       hardcoded the reservoir size




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org