You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/09/06 09:53:05 UTC
[GitHub] [inlong] woofyzhao opened a new pull request, #5807: [INLONG-5799][Manager] Fix the source delete/stop/restart bug
woofyzhao opened a new pull request, #5807:
URL: https://github.com/apache/inlong/pull/5807
- Fixes #5799
### Motivation
1. the template task should not be operated
2. fix the incorrect status predicator
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #5807: [INLONG-5799][Manager] Fix the source delete/stop/restart bug
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #5807:
URL: https://github.com/apache/inlong/pull/5807
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #5807: [INLONG-5799][Manager] Fix the source delete/stop/restart bug
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5807:
URL: https://github.com/apache/inlong/pull/5807#discussion_r963618386
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/listener/source/AbstractSourceOperateListener.java:
##########
@@ -99,6 +99,10 @@ protected void operateStreamSources(String groupId, String streamId, String oper
*/
@SneakyThrows
public boolean checkIfOp(StreamSource streamSource, List<StreamSource> unOperatedSources) {
+ // template source task need not be operated
Review Comment:
Where are the sub-sources operated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] woofyzhao commented on a diff in pull request #5807: [INLONG-5799][Manager] Fix the source delete/stop/restart bug
Posted by GitBox <gi...@apache.org>.
woofyzhao commented on code in PR #5807:
URL: https://github.com/apache/inlong/pull/5807#discussion_r963623944
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/listener/source/AbstractSourceOperateListener.java:
##########
@@ -99,6 +99,10 @@ protected void operateStreamSources(String groupId, String streamId, String oper
*/
@SneakyThrows
public boolean checkIfOp(StreamSource streamSource, List<StreamSource> unOperatedSources) {
+ // template source task need not be operated
Review Comment:
Also here. The template task is filtered.
Comments added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org