[jira] [Commented] (PHOENIX-910) Filter should override hasFilterRow() when filterRow() is overridden

["Anoop Sam John (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967007#comment-13967007 ] 

Anoop Sam John commented on PHOENIX-910:
----------------------------------------

Implementing this will make us to hit the issue HBASE-10850.  So pls consider fixing this only on later versions when we have HBase versions with fix for HBASE-10850 available.

> Filter should override hasFilterRow() when filterRow() is overridden
> --------------------------------------------------------------------
>
>                 Key: PHOENIX-910
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-910
>             Project: Phoenix
>          Issue Type: Task
>            Reporter: Ted Yu
>
> There're 3 Filters where filterRow() is overridden but hasFilterRow() is not:
> {code}
>     public boolean filterRow() {
> ./phoenix-core/src/main/java/org/apache/phoenix/filter/MultiKeyValueComparisonFilter.java
>     public boolean filterRow() {
> ./phoenix-core/src/main/java/org/apache/phoenix/filter/RowKeyComparisonFilter.java
>     public boolean filterRow() {
> ./phoenix-core/src/main/java/org/apache/phoenix/filter/SingleKeyValueComparisonFilter.java
> {code}
> hasFilterRow() should be overridden and return true.



--
This message was sent by Atlassian JIRA
(v6.2#6252)