You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/03 11:35:00 UTC

[GitHub] [incubator-nuttx-apps] anchao commented on a change in pull request #161: netutils/dhcpc: configurable timeout and retry count.

anchao commented on a change in pull request #161: netutils/dhcpc: configurable timeout and retry count.
URL: https://github.com/apache/incubator-nuttx-apps/pull/161#discussion_r402943092
 
 

 ##########
 File path: netutils/dhcpc/dhcpc.c
 ##########
 @@ -433,7 +433,7 @@ FAR void *dhcpc_open(FAR const char *interface, FAR const void *macaddr,
 
       /* Configure for read timeouts */
 
-      tv.tv_sec  = 10;
+      tv.tv_sec  = CONFIG_NETUTILS_DHCPC_RECV_TIMEOUT;
 
 Review comment:
   DHCP client uses the UDP protocol to transmit, which is not reliable because sometime the dhcp request packet may not be accurately sent to the server if the signal is very weak, configurable options are also a good choose to change the behavior of  dhcpc.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services