You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by tgravescs <gi...@git.apache.org> on 2018/08/02 18:25:31 UTC

[GitHub] spark pull request #21809: [SPARK-24851][UI] Map a Stage ID to it's Associat...

Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21809#discussion_r207324015
  
    --- Diff: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala ---
    @@ -112,10 +112,13 @@ private[spark] class AppStatusStore(
         }
       }
     
    -  def stageAttempt(stageId: Int, stageAttemptId: Int, details: Boolean = false): v1.StageData = {
    +  def stageAttempt(stageId: Int, stageAttemptId: Int,
    +    details: Boolean = false): (v1.StageData, Seq[Int]) = {
         val stageKey = Array(stageId, stageAttemptId)
    -    val stage = store.read(classOf[StageDataWrapper], stageKey).info
    -    if (details) stageWithDetails(stage) else stage
    +    val stageDataWrapper: StageDataWrapper = store.read(classOf[StageDataWrapper], stageKey)
    --- End diff --
    
    you don't really need the type here (: StageDataWrapper) 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org