You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "anishshri-db (via GitHub)" <gi...@apache.org> on 2023/08/14 22:35:30 UTC
[GitHub] [spark] anishshri-db opened a new pull request, #42491: [SPARK-44809] Removed unused RocksDB custom metrics for pause/writeBatch
anishshri-db opened a new pull request, #42491:
URL: https://github.com/apache/spark/pull/42491
### What changes were proposed in this pull request?
Removed unused RocksDB custom metrics for pause/writeBatch
### Why are the changes needed?
Remove unused metrics from query progress
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Modified existing tests
```
[info] Run completed in 23 seconds, 724 milliseconds.
[info] Total number of tests run: 11
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 11, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 53 s, completed Aug 14, 2023, 3:30:56 PM
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR closed pull request #42491: [SPARK-44809][SS] Remove unused RocksDB custom metrics for pause/writeBatch
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR closed pull request #42491: [SPARK-44809][SS] Remove unused RocksDB custom metrics for pause/writeBatch
URL: https://github.com/apache/spark/pull/42491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] anishshri-db commented on pull request #42491: [SPARK-44809][SS] Remove unused RocksDB custom metrics for pause/writeBatch
Posted by "anishshri-db (via GitHub)" <gi...@apache.org>.
anishshri-db commented on PR #42491:
URL: https://github.com/apache/spark/pull/42491#issuecomment-1678175903
cc - @HeartSaVioR - PTAL, thx !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #42491: [SPARK-44809][SS] Remove unused RocksDB custom metrics for pause/writeBatch
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR commented on PR #42491:
URL: https://github.com/apache/spark/pull/42491#issuecomment-1679865582
https://github.com/anishshri-db/spark/actions/runs/5861353460/attempts/2 <= This passed.
Thanks! Merging to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] anishshri-db commented on pull request #42491: [SPARK-44809][SS] Remove unused RocksDB custom metrics for pause/writeBatch
Posted by "anishshri-db (via GitHub)" <gi...@apache.org>.
anishshri-db commented on PR #42491:
URL: https://github.com/apache/spark/pull/42491#issuecomment-1678334825
I don't think error is related to the change. Seems like a transient/timing issue with awaitOffset. Locally, tests run fine. Ran suite multiple times
```
[info] Run completed in 31 seconds, 40 milliseconds.
[info] Total number of tests run: 8
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 8, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] anishshri-db commented on pull request #42491: [SPARK-44809][SS] Remove unused RocksDB custom metrics for pause/writeBatch
Posted by "anishshri-db (via GitHub)" <gi...@apache.org>.
anishshri-db commented on PR #42491:
URL: https://github.com/apache/spark/pull/42491#issuecomment-1679853854
All tests passing fine now - https://github.com/anishshri-db/spark/actions/runs/5861353460/job/15927525392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #42491: [SPARK-44809][SS] Remove unused RocksDB custom metrics for pause/writeBatch
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR commented on PR #42491:
URL: https://github.com/apache/spark/pull/42491#issuecomment-1679782382
@anishshri-db Can we retry the build for completeness' sake?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org