You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Rafael H. Schloming (JIRA)" <qp...@incubator.apache.org> on 2007/09/04 21:08:44 UTC

[jira] Created: (QPID-574) the java client unnecessarily rejects messages prior to rollback, and the java broker appears to depend on this behavior

the java client unnecessarily rejects messages prior to rollback, and the java broker appears to depend on this behavior
------------------------------------------------------------------------------------------------------------------------

                 Key: QPID-574
                 URL: https://issues.apache.org/jira/browse/QPID-574
             Project: Qpid
          Issue Type: Bug
          Components: Java Broker, Java Client
            Reporter: Rafael H. Schloming


The java client rejects all messages prior to rollback. This should not cause a problem with any compliant broker as the effect of the reject will be rolled back, however it should not be necessary. Commenting out these rejects causes test failures. This may indicate that the broker somehow depends on this behavior in order to correctly rollback a session. If so the broker will have trouble interoperating with other conformant clients. Additionally the java client appears to hold back all message acknowledgments until the transaction commits. I'm guessing this is to avoid first acknowledging and then rejecting the same message when a rollback occurs. If the reject is removed, this behavior could probably be simplified.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (QPID-574) the java client unnecessarily rejects messages prior to rollback, and the java broker appears to depend on this behavior

Posted by "Marnie McCormack (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marnie McCormack updated QPID-574:
----------------------------------

    Fix Version/s:     (was: M4)

Moving items not being worked on afaik out of M4 Fix Version

> the java client unnecessarily rejects messages prior to rollback, and the java broker appears to depend on this behavior
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-574
>                 URL: https://issues.apache.org/jira/browse/QPID-574
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker, Java Client
>            Reporter: Rafael H. Schloming
>            Assignee: Aidan Skinner
>
> The java client rejects all messages prior to rollback. This should not cause a problem with any compliant broker as the effect of the reject will be rolled back, however it should not be necessary. Commenting out these rejects causes test failures. This may indicate that the broker somehow depends on this behavior in order to correctly rollback a session. If so the broker will have trouble interoperating with other conformant clients. Additionally the java client appears to hold back all message acknowledgments until the transaction commits. I'm guessing this is to avoid first acknowledging and then rejecting the same message when a rollback occurs. If the reject is removed, this behavior could probably be simplified.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (QPID-574) the java client unnecessarily rejects messages prior to rollback, and the java broker appears to depend on this behavior

Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Ritchie updated QPID-574:
--------------------------------

    Fix Version/s: M2.1

> the java client unnecessarily rejects messages prior to rollback, and the java broker appears to depend on this behavior
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-574
>                 URL: https://issues.apache.org/jira/browse/QPID-574
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker, Java Client
>            Reporter: Rafael H. Schloming
>             Fix For: M2.1
>
>
> The java client rejects all messages prior to rollback. This should not cause a problem with any compliant broker as the effect of the reject will be rolled back, however it should not be necessary. Commenting out these rejects causes test failures. This may indicate that the broker somehow depends on this behavior in order to correctly rollback a session. If so the broker will have trouble interoperating with other conformant clients. Additionally the java client appears to hold back all message acknowledgments until the transaction commits. I'm guessing this is to avoid first acknowledging and then rejecting the same message when a rollback occurs. If the reject is removed, this behavior could probably be simplified.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (QPID-574) the java client unnecessarily rejects messages prior to rollback, and the java broker appears to depend on this behavior

Posted by "Rafael H. Schloming (JIRA)" <qp...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12525088 ] 

Rafael H. Schloming commented on QPID-574:
------------------------------------------

After reviewing the specification I think this behavior actually would cause a problem with a complient broker since the rejected messages may be dead letter queued, and certainly wouldn't be redelivered to the same client as would be expected if the client were to issue a rollback without rejecting the messages.

> the java client unnecessarily rejects messages prior to rollback, and the java broker appears to depend on this behavior
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-574
>                 URL: https://issues.apache.org/jira/browse/QPID-574
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker, Java Client
>            Reporter: Rafael H. Schloming
>
> The java client rejects all messages prior to rollback. This should not cause a problem with any compliant broker as the effect of the reject will be rolled back, however it should not be necessary. Commenting out these rejects causes test failures. This may indicate that the broker somehow depends on this behavior in order to correctly rollback a session. If so the broker will have trouble interoperating with other conformant clients. Additionally the java client appears to hold back all message acknowledgments until the transaction commits. I'm guessing this is to avoid first acknowledging and then rejecting the same message when a rollback occurs. If the reject is removed, this behavior could probably be simplified.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (QPID-574) the java client unnecessarily rejects messages prior to rollback, and the java broker appears to depend on this behavior

Posted by "Aidan Skinner (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aidan Skinner updated QPID-574:
-------------------------------

    Fix Version/s:     (was: M2.1)
                   M3

> the java client unnecessarily rejects messages prior to rollback, and the java broker appears to depend on this behavior
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-574
>                 URL: https://issues.apache.org/jira/browse/QPID-574
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker, Java Client
>            Reporter: Rafael H. Schloming
>             Fix For: M3
>
>
> The java client rejects all messages prior to rollback. This should not cause a problem with any compliant broker as the effect of the reject will be rolled back, however it should not be necessary. Commenting out these rejects causes test failures. This may indicate that the broker somehow depends on this behavior in order to correctly rollback a session. If so the broker will have trouble interoperating with other conformant clients. Additionally the java client appears to hold back all message acknowledgments until the transaction commits. I'm guessing this is to avoid first acknowledging and then rejecting the same message when a rollback occurs. If the reject is removed, this behavior could probably be simplified.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.