You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2022/07/05 12:25:20 UTC
[GitHub] [ratis] codings-dan opened a new pull request, #670: RATIS-1614. Upgrade Ratis Thirdparty to 1.0.1
codings-dan opened a new pull request, #670:
URL: https://github.com/apache/ratis/pull/670
## What changes were proposed in this pull request?
Upgrade Ratis Thirdparty to 1.0.1, which has the following (non-test) changes:
RATIS-1585. Bump gson to 2.8.9
RATIS-1591. Bump netty to 4.1.77
RATIS-1595. Shade dropwizard 4.x in ratis-thirdparty
RATIS-1601. Use the shaded dropwizard metrics and remove the dependency
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-1614
https://issues.apache.org/jira/browse/RATIS-1601
## How was this patch tested?
https://github.com/codings-dan/incubator-ratis/actions/runs/2616031344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] codings-dan commented on pull request #670: RATIS-1614. Upgrade Ratis Thirdparty to 1.0.1
Posted by GitBox <gi...@apache.org>.
codings-dan commented on PR #670:
URL: https://github.com/apache/ratis/pull/670#issuecomment-1174999834
@szetszwo Could you help review this pull request, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] codings-dan commented on a diff in pull request #670: RATIS-1614. Upgrade Ratis Thirdparty to 1.0.1
Posted by GitBox <gi...@apache.org>.
codings-dan commented on code in PR #670:
URL: https://github.com/apache/ratis/pull/670#discussion_r915734511
##########
pom.xml:
##########
@@ -407,25 +407,25 @@
<dependency>
<groupId>io.dropwizard.metrics</groupId>
<artifactId>metrics-core</artifactId>
- <version>${dropwizard.version}</version>
+ <version>${shaded.dropwizard.version}</version>
</dependency>
<dependency>
<groupId>io.dropwizard.metrics</groupId>
<artifactId>metrics-jvm</artifactId>
- <version>${dropwizard.version}</version>
+ <version>${shaded.dropwizard.version}</version>
</dependency>
<dependency>
<groupId>io.dropwizard.metrics</groupId>
<artifactId>metrics-jmx</artifactId>
- <version>${dropwizard.version}</version>
+ <version>${shaded.dropwizard.version}</version>
</dependency>
<dependency>
<groupId>io.dropwizard.metrics</groupId>
<artifactId>metrics-ganglia</artifactId>
- <version>${dropwizard.ganglia.version}</version>
+ <version>${shaded.dropwizard.ganglia.version}</version>
</dependency>
Review Comment:
@szetszwo Thanks for pointing out the problem, I'm not very familiar with this part, so I missed some changes. I've made a new pull request, please take a look, thanks! see https://github.com/apache/ratis/pull/671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] codings-dan commented on pull request #670: RATIS-1614. Upgrade Ratis Thirdparty to 1.0.1
Posted by GitBox <gi...@apache.org>.
codings-dan commented on PR #670:
URL: https://github.com/apache/ratis/pull/670#issuecomment-1175746965
@szetszwo Thanks for helping review and merging the pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] szetszwo merged pull request #670: RATIS-1614. Upgrade Ratis Thirdparty to 1.0.1
Posted by GitBox <gi...@apache.org>.
szetszwo merged PR #670:
URL: https://github.com/apache/ratis/pull/670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] szetszwo commented on a diff in pull request #670: RATIS-1614. Upgrade Ratis Thirdparty to 1.0.1
Posted by GitBox <gi...@apache.org>.
szetszwo commented on code in PR #670:
URL: https://github.com/apache/ratis/pull/670#discussion_r915091007
##########
pom.xml:
##########
@@ -407,25 +407,25 @@
<dependency>
<groupId>io.dropwizard.metrics</groupId>
<artifactId>metrics-core</artifactId>
- <version>${dropwizard.version}</version>
+ <version>${shaded.dropwizard.version}</version>
</dependency>
<dependency>
<groupId>io.dropwizard.metrics</groupId>
<artifactId>metrics-jvm</artifactId>
- <version>${dropwizard.version}</version>
+ <version>${shaded.dropwizard.version}</version>
</dependency>
<dependency>
<groupId>io.dropwizard.metrics</groupId>
<artifactId>metrics-jmx</artifactId>
- <version>${dropwizard.version}</version>
+ <version>${shaded.dropwizard.version}</version>
</dependency>
<dependency>
<groupId>io.dropwizard.metrics</groupId>
<artifactId>metrics-ganglia</artifactId>
- <version>${dropwizard.ganglia.version}</version>
+ <version>${shaded.dropwizard.ganglia.version}</version>
</dependency>
Review Comment:
Oops, we should remove all the dropwizard dependencies and change all the imports to org.apache.ratis.thirdparty.com.codahale.metrics.*
@codings-dan , I have reopened RATIS-1601.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org