You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/19 05:30:25 UTC

[GitHub] [spark] gengliangwang commented on pull request #28805: [SPARK-28169][SQL] Convert scan predicate condition to CNF

gengliangwang commented on pull request #28805:
URL: https://github.com/apache/spark/pull/28805#issuecomment-646443250


   > In this case, Spark will resolve Or condition as one expression, and since this expr has reference of "id", then it can't been push down.
   
   Sorry, could you explain more here? 
   The CNF process should break down `dt = 20190626 and id in (1,2,3)` to `Seq((dt = 20190626), (id in (1,2,3))`, and then these two sub-predicates will be processed in `groupExpressionsByQualifier`. What is the problem here?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org