[GitHub] [buildstream] gtristan commented on pull request #1701: Fix loading cross project element

[GitBox <gi...@apache.org>]

gtristan commented on PR #1701:
URL: https://github.com/apache/buildstream/pull/1701#issuecomment-1193781702

   This patch apparently fixes the issue in question, however it does not appear to be the best/correct fix.
   
   We have two behaviors which should be equal:
   
   * `bst show subproject.bst:target.bst` This is showing a stack trace
   
   * `bst show target.bst` where the toplevel project `target.bst` depends on `subproject.bst:target.bst`, This is not showing a stack trace.
   
   The current fix causes the first variant to not produce a stack trace, but exercises a clearly different load pattern - it would be better to not cause the core to accomadate the second loading pattern but instead cause both use cases to exercise the same loading pattern.
   
   It is still unclear why they are not behaving the same way.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org