You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/06 09:54:06 UTC

[GitHub] [pulsar] eolivelli commented on a diff in pull request #16399: [improve][broker] Recycle OpReadEntry in some corner cases

eolivelli commented on code in PR #16399:
URL: https://github.com/apache/pulsar/pull/16399#discussion_r914648887


##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpReadEntry.java:
##########
@@ -34,6 +36,9 @@
 
 class OpReadEntry implements ReadEntriesCallback {
 
+    private static AtomicInteger createCount = null;

Review Comment:
   we should do this with PowerMock
   
   please do not add such instrumentation only for testing



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org