You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/05/10 13:01:49 UTC
[GitHub] [netbeans] sdedic opened a new pull request, #4097: Fix 'node id XXX already exists' error in vscode.
sdedic opened a new pull request, #4097:
URL: https://github.com/apache/netbeans/pull/4097
The bug manifests in several places. Most notably in vscode DB Explorer where a `Refresh` action causes vscode-nbls communication to fail with `Node xxx is already present`. This is caused by creation of a new node - a new identity, which is equal() to the previously created node, which is still in the map (since the client may still ask for its details).
And that node is created (since keys - underlying DB data) did not actually even change is done because of some of DB children use `ChildFactory` SPI from Nodes - this is the other fix. It turned out that `add` method of the `j.u.List` passed to `ChildFactory.createKeys()` is tweaked so it detects actual addition beyond the original content - and causes interim keys refresh, which, in turn, causes Node removal for whose keys are not (yet) present, since the `ChildFactory` did not add them.
Note that this fix is not a complete fix - if a (really) new node is inserted among existing, the nodes will be destroyed + recreated. I think it is probably impossible to fix without breaking Children and its event semantics. But the fix corrects situation when the content actually does not change or is only added to.
@jhorvath please decide whether the fix should go to `master` or it is critical for DB explorer (where it mainly appears, but I've encountered it elsewhere as well) so `vscode` extension could benefit from inclusion in NB14.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #4097: Fix 'node id XXX already exists' error in vscode.
Posted by GitBox <gi...@apache.org>.
sdedic commented on PR #4097:
URL: https://github.com/apache/netbeans/pull/4097#issuecomment-1125944349
> @sdedic for ping :D
Sorry, had offline discussion about impact / importance / stability of this. Will rebase in ~1 hour.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on pull request #4097: Fix 'node id XXX already exists' error in vscode.
Posted by GitBox <gi...@apache.org>.
ebarboni commented on PR #4097:
URL: https://github.com/apache/netbeans/pull/4097#issuecomment-1125883938
@sdedic for ping :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jhorvath commented on pull request #4097: Fix 'node id XXX already exists' error in vscode.
Posted by GitBox <gi...@apache.org>.
jhorvath commented on PR #4097:
URL: https://github.com/apache/netbeans/pull/4097#issuecomment-1125123500
>
@sdedic please include this fix also NB14 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #4097: Fix 'node id XXX already exists' error in vscode.
Posted by GitBox <gi...@apache.org>.
sdedic commented on PR #4097:
URL: https://github.com/apache/netbeans/pull/4097#issuecomment-1125287635
Let's include RMs @neilcsmith-net and @ebarboni to decide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on pull request #4097: Fix 'node id XXX already exists' error in vscode.
Posted by GitBox <gi...@apache.org>.
ebarboni commented on PR #4097:
URL: https://github.com/apache/netbeans/pull/4097#issuecomment-1125306604
hi, we have a regression with a fix under review so rc4 is expected. If you rebase on delivery it can be merged. I will also merge nb-javac 18 pr but tomorrow :D.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni merged pull request #4097: Fix 'node id XXX already exists' error in vscode.
Posted by GitBox <gi...@apache.org>.
ebarboni merged PR #4097:
URL: https://github.com/apache/netbeans/pull/4097
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #4097: Fix 'node id XXX already exists' error in vscode.
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on PR #4097:
URL: https://github.com/apache/netbeans/pull/4097#issuecomment-1122382256
Well this one affects every project which using Async children. I do not see anything bad on the first glimpse, but I'm nowhere a node api expert. Asked @jtulach as well. The change is fine for me, though I do not feel myself qualified enough to approve it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #4097: Fix 'node id XXX already exists' error in vscode.
Posted by GitBox <gi...@apache.org>.
sdedic commented on PR #4097:
URL: https://github.com/apache/netbeans/pull/4097#issuecomment-1126805718
Had to fix the code, wrong analysis done w.r.t. handling of the Wait node. Now the code is simpler -- there's one extra entry, which is subtracted -- Math.max(0, x) is there just in case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #4097: Fix 'node id XXX already exists' error in vscode.
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on PR #4097:
URL: https://github.com/apache/netbeans/pull/4097#issuecomment-1125127064
I think it's too late for NB14. Theoretically we shall create the first voting candidate today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on pull request #4097: Fix 'node id XXX already exists' error in vscode.
Posted by GitBox <gi...@apache.org>.
ebarboni commented on PR #4097:
URL: https://github.com/apache/netbeans/pull/4097#issuecomment-1126690167
@sdedic a test isssue occurs on platform/openide.nodes in travis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists