You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "Pengzna (via GitHub)" <gi...@apache.org> on 2024/12/18 07:57:23 UTC
Re: [PR] [region migration] Make peer list correct when IoTConsensus and IoTConsensusV2 starting [iotdb]
Pengzna commented on code in PR #14447:
URL: https://github.com/apache/iotdb/pull/14447#discussion_r1889777662
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/consensus/ConsensusPipeDataNodeDispatcher.java:
##########
@@ -111,6 +119,10 @@ public void dropPipe(ConsensusPipeName pipeName) throws Exception {
final TSStatus status = configNodeClient.dropPipe(pipeName.toString());
if (TSStatusCode.SUCCESS_STATUS.getStatusCode() != status.getCode()) {
LOGGER.warn("Failed to drop consensus pipe-{}, status: {}", pipeName, status);
+ // ignore idempotence logic
+ if (status.getMessage().contains(PIPE_NOT_EXIST_MGS)) {
+ return;
+ }
Review Comment:
fixed, PTAL
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/consensus/ConsensusPipeDataNodeDispatcher.java:
##########
@@ -64,6 +68,10 @@ public void createPipe(
TSStatus status = configNodeClient.createPipe(req);
if (TSStatusCode.SUCCESS_STATUS.getStatusCode() != status.getCode()) {
LOGGER.warn("Failed to create consensus pipe-{}, status: {}", pipeName, status);
+ // ignore idempotence logic
+ if (status.getMessage().contains(PIPE_ALREADY_EXIST_MSG)) {
+ return;
+ }
Review Comment:
fixed, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org