You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/22 08:38:53 UTC
[GitHub] [flink] gaoyunhaii opened a new pull request #11858: [FLINK-17182] Stop waiting on the buffer provide when exclusive buffer fulfills the required buffers
gaoyunhaii opened a new pull request #11858:
URL: https://github.com/apache/flink/pull/11858
## What is the purpose of the change
This PR tries to fix the issue caused by not stopping waiting on the buffer provider when the required buffers are fulfilled when recycling the exclusive buffers. If we do not stop waiting, we could not reuse the floating buffers returned when recycling the exclusive buffers.
Special care needs to taken that there might be case that the listener has been picked out from the buffer pool for notifying of new buffer when the input channel is adding exclusive buffer. In this case, the listener would not actually removed from the provider and we could not reset the waiting flag, otherwise the listener might be added twice in the buffer provider.
## Brief change log
- fa6a9de78920441c0b562e936b8a438776ab4bbe removes the listener when the when exclusive buffer fulfills the required buffers.
## Verifying this change
This change added tests and can be verified as follows:
- Add UT to verify the waiting is stopped as expected.
- The failure in [FLINK-17182](https://issues.apache.org/jira/browse/FLINK-17182) does not occurs when running that UT repeatedly.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no**
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: **no**
- The S3 file system connector: **no**
## Documentation
- Does this pull request introduce a new feature? **no**
- If yes, how is the feature documented? **not applicable**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on issue #11858: [FLINK-17182][network] Stop waiting on the buffer provide when exclusive buffer fulfills the required buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11858:
URL: https://github.com/apache/flink/pull/11858#issuecomment-617655198
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "49f9b0f2b455320471126a138f8d56de430372d9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=55",
"triggerID" : "49f9b0f2b455320471126a138f8d56de430372d9",
"triggerType" : "PUSH"
}, {
"hash" : "49f9b0f2b455320471126a138f8d56de430372d9",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161400070",
"triggerID" : "49f9b0f2b455320471126a138f8d56de430372d9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 49f9b0f2b455320471126a138f8d56de430372d9 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/161400070) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=55)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on issue #11858: [FLINK-17182][network] Stop waiting on the buffer provide when exclusive buffer fulfills the required buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11858:
URL: https://github.com/apache/flink/pull/11858#issuecomment-617655198
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "49f9b0f2b455320471126a138f8d56de430372d9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=55",
"triggerID" : "49f9b0f2b455320471126a138f8d56de430372d9",
"triggerType" : "PUSH"
}, {
"hash" : "49f9b0f2b455320471126a138f8d56de430372d9",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161400070",
"triggerID" : "49f9b0f2b455320471126a138f8d56de430372d9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 49f9b0f2b455320471126a138f8d56de430372d9 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/161400070) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=55)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on issue #11858: [FLINK-17182][network] Stop waiting on the buffer provide when exclusive buffer fulfills the required buffers
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11858:
URL: https://github.com/apache/flink/pull/11858#issuecomment-617639314
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit fa6a9de78920441c0b562e936b8a438776ab4bbe (Wed Apr 22 08:41:20 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on issue #11858: [FLINK-17182][network] Stop waiting on the buffer provide when exclusive buffer fulfills the required buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11858:
URL: https://github.com/apache/flink/pull/11858#issuecomment-617655198
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "49f9b0f2b455320471126a138f8d56de430372d9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=55",
"triggerID" : "49f9b0f2b455320471126a138f8d56de430372d9",
"triggerType" : "PUSH"
}, {
"hash" : "49f9b0f2b455320471126a138f8d56de430372d9",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161400070",
"triggerID" : "49f9b0f2b455320471126a138f8d56de430372d9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 49f9b0f2b455320471126a138f8d56de430372d9 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/161400070) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=55)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on issue #11858: [FLINK-17182][network] Stop waiting on the buffer provide when exclusive buffer fulfills the required buffers
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11858:
URL: https://github.com/apache/flink/pull/11858#issuecomment-617655198
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "49f9b0f2b455320471126a138f8d56de430372d9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "49f9b0f2b455320471126a138f8d56de430372d9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 49f9b0f2b455320471126a138f8d56de430372d9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org