You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/22 16:15:10 UTC

[GitHub] [flink] twalthr opened a new pull request #10928: [FLINK-15487][table-common] Make TypeInference mandatory for function definitions

twalthr opened a new pull request #10928: [FLINK-15487][table-common] Make TypeInference mandatory for function definitions
URL: https://github.com/apache/flink/pull/10928
 
 
   ## What is the purpose of the change
   
   This makes `TypeInference` mandatory for function definitions and updates the documentation of `ScalarFunction`s.
   
   ## Brief change log
   
   - Update `FunctionDefinition`, `UserDefinedFunction`, and `ScalarFunction`
   
   ## Verifying this change
   
   This change is already covered by existing tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: yes
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? JavaDocs
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10928: [FLINK-15487][table-common] Make TypeInference mandatory for function definitions

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10928: [FLINK-15487][table-common] Make TypeInference mandatory for function definitions
URL: https://github.com/apache/flink/pull/10928#issuecomment-577284961
 
 
   <!--
   Meta data
   Hash:b26be0d53c9159e5b3451deef88d6a1e4e9c7a73 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/145595478 TriggerType:PUSH TriggerID:b26be0d53c9159e5b3451deef88d6a1e4e9c7a73
   Hash:b26be0d53c9159e5b3451deef88d6a1e4e9c7a73 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4562 TriggerType:PUSH TriggerID:b26be0d53c9159e5b3451deef88d6a1e4e9c7a73
   -->
   ## CI report:
   
   * b26be0d53c9159e5b3451deef88d6a1e4e9c7a73 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/145595478) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4562) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] twalthr commented on issue #10928: [FLINK-15487][table-common] Make TypeInference mandatory for function definitions

Posted by GitBox <gi...@apache.org>.
twalthr commented on issue #10928: [FLINK-15487][table-common] Make TypeInference mandatory for function definitions
URL: https://github.com/apache/flink/pull/10928#issuecomment-577632823
 
 
   Thanks for the review @dawidwys. I will address your minor comments while merging.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10928: [FLINK-15487][table-common] Make TypeInference mandatory for function definitions

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10928: [FLINK-15487][table-common] Make TypeInference mandatory for function definitions
URL: https://github.com/apache/flink/pull/10928#issuecomment-577284961
 
 
   <!--
   Meta data
   Hash:b26be0d53c9159e5b3451deef88d6a1e4e9c7a73 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:b26be0d53c9159e5b3451deef88d6a1e4e9c7a73
   -->
   ## CI report:
   
   * b26be0d53c9159e5b3451deef88d6a1e4e9c7a73 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10928: [FLINK-15487][table-common] Make TypeInference mandatory for function definitions

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10928: [FLINK-15487][table-common] Make TypeInference mandatory for function definitions
URL: https://github.com/apache/flink/pull/10928#issuecomment-577284961
 
 
   <!--
   Meta data
   Hash:b26be0d53c9159e5b3451deef88d6a1e4e9c7a73 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145595478 TriggerType:PUSH TriggerID:b26be0d53c9159e5b3451deef88d6a1e4e9c7a73
   Hash:b26be0d53c9159e5b3451deef88d6a1e4e9c7a73 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4562 TriggerType:PUSH TriggerID:b26be0d53c9159e5b3451deef88d6a1e4e9c7a73
   -->
   ## CI report:
   
   * b26be0d53c9159e5b3451deef88d6a1e4e9c7a73 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145595478) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4562) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10928: [FLINK-15487][table-common] Make TypeInference mandatory for function definitions

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10928: [FLINK-15487][table-common] Make TypeInference mandatory for function definitions
URL: https://github.com/apache/flink/pull/10928#issuecomment-577264442
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit b26be0d53c9159e5b3451deef88d6a1e4e9c7a73 (Wed Jan 22 16:18:09 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] dawidwys commented on a change in pull request #10928: [FLINK-15487][table-common] Make TypeInference mandatory for function definitions

Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #10928: [FLINK-15487][table-common] Make TypeInference mandatory for function definitions
URL: https://github.com/apache/flink/pull/10928#discussion_r369992703
 
 

 ##########
 File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/ScalarFunctionDefinition.java
 ##########
 @@ -53,6 +56,11 @@ public FunctionKind getKind() {
 		return FunctionKind.SCALAR;
 	}
 
+	@Override
+	public TypeInference getTypeInference(DataTypeFactory factory) {
 
 Review comment:
   nit: 
   1. The whole class should be `@Internal`
   2. Could we add a comment on top of this class that this is a marker interface to use the old type stack for the function?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] twalthr closed pull request #10928: [FLINK-15487][table-common] Make TypeInference mandatory for function definitions

Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #10928: [FLINK-15487][table-common] Make TypeInference mandatory for function definitions
URL: https://github.com/apache/flink/pull/10928
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services