You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/27 01:59:04 UTC

[GitHub] [flink] yuchuanchen commented on a change in pull request #13718: [FLINK-18811] Pick another tmpDir if an IOException occurs when creating spill file

yuchuanchen commented on a change in pull request #13718:
URL: https://github.com/apache/flink/pull/13718#discussion_r512370998



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpanningWrapper.java
##########
@@ -286,11 +292,21 @@ private FileChannel createSpillingChannel() throws IOException {
 		// try to find a unique file name for the spilling channel
 		int maxAttempts = 10;
 		for (int attempt = 0; attempt < maxAttempts; attempt++) {
-			String directory = tempDirs[rnd.nextInt(tempDirs.length)];
+			int dirIndex = rnd.nextInt(tempDirs.length);

Review comment:
       yeah,that's a good idea.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org