You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2017/04/25 16:37:56 UTC
Review Request 58713: Remove Refresh Query Hint From Upgrade DAO
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58713/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Nate Cole, and Sid Wagle.
Bugs: AMBARI-20847
https://issues.apache.org/jira/browse/AMBARI-20847
Repository: ambari
Description
-------
Repeated requests to the org.apache.ambari.server.orm.dao.UpgradeDAO methods during upgrades can cause large delays retrieving active upgrades. This is because the QueryHint.REFRESH is being used in almost every method. This causes a re-read on every UpgradeEntity -> UpgradeGroupEntity -> UpgradeItemEntity in the entire database for every query.
These query hints should be removed.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java 4666edf
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java de1454b
Diff: https://reviews.apache.org/r/58713/diff/1/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:14 min
[INFO] Finished at: 2017-04-25T11:25:32-04:00
[INFO] Final Memory: 67M/770M
[INFO] ------------------------------------------------------------------------
Thanks,
Jonathan Hurley
Re: Review Request 58713: Remove Refresh Query Hint From Upgrade DAO
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58713/#review172949
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On April 25, 2017, 4:37 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58713/
> -----------------------------------------------------------
>
> (Updated April 25, 2017, 4:37 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Sid Wagle.
>
>
> Bugs: AMBARI-20847
> https://issues.apache.org/jira/browse/AMBARI-20847
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Repeated requests to the org.apache.ambari.server.orm.dao.UpgradeDAO methods during upgrades can cause large delays retrieving active upgrades. This is because the QueryHint.REFRESH is being used in almost every method. This causes a re-read on every UpgradeEntity -> UpgradeGroupEntity -> UpgradeItemEntity in the entire database for every query.
> These query hints should be removed.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java 4666edf
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java de1454b
>
>
> Diff: https://reviews.apache.org/r/58713/diff/1/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:14 min
> [INFO] Finished at: 2017-04-25T11:25:32-04:00
> [INFO] Final Memory: 67M/770M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 58713: Remove Refresh Query Hint From Upgrade DAO
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58713/#review172957
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On April 25, 2017, 4:37 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58713/
> -----------------------------------------------------------
>
> (Updated April 25, 2017, 4:37 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Sid Wagle.
>
>
> Bugs: AMBARI-20847
> https://issues.apache.org/jira/browse/AMBARI-20847
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Repeated requests to the org.apache.ambari.server.orm.dao.UpgradeDAO methods during upgrades can cause large delays retrieving active upgrades. This is because the QueryHint.REFRESH is being used in almost every method. This causes a re-read on every UpgradeEntity -> UpgradeGroupEntity -> UpgradeItemEntity in the entire database for every query.
> These query hints should be removed.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java 4666edf
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java de1454b
>
>
> Diff: https://reviews.apache.org/r/58713/diff/1/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:14 min
> [INFO] Finished at: 2017-04-25T11:25:32-04:00
> [INFO] Final Memory: 67M/770M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 58713: Remove Refresh Query Hint From Upgrade DAO
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58713/#review172970
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On April 25, 2017, 12:37 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58713/
> -----------------------------------------------------------
>
> (Updated April 25, 2017, 12:37 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Sid Wagle.
>
>
> Bugs: AMBARI-20847
> https://issues.apache.org/jira/browse/AMBARI-20847
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Repeated requests to the org.apache.ambari.server.orm.dao.UpgradeDAO methods during upgrades can cause large delays retrieving active upgrades. This is because the QueryHint.REFRESH is being used in almost every method. This causes a re-read on every UpgradeEntity -> UpgradeGroupEntity -> UpgradeItemEntity in the entire database for every query.
> These query hints should be removed.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java 4666edf
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java de1454b
>
>
> Diff: https://reviews.apache.org/r/58713/diff/1/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:14 min
> [INFO] Finished at: 2017-04-25T11:25:32-04:00
> [INFO] Final Memory: 67M/770M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jonathan Hurley
>
>