[GitHub] [hudi] sbernauer commented on a change in pull request #3172: [HUDI-2069] Refactored String constants

[GitBox <gi...@apache.org>]

sbernauer commented on a change in pull request #3172:
URL: https://github.com/apache/hudi/pull/3172#discussion_r663328857



##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/AvroKafkaSource.java
##########
@@ -60,7 +66,7 @@ public AvroKafkaSource(TypedProperties props, JavaSparkContext sparkContext, Spa
     super(props, sparkContext, sparkSession, schemaProvider);
 
     props.put(NATIVE_KAFKA_KEY_DESERIALIZER_PROP, StringDeserializer.class);
-    String deserializerClassName = props.getString(DataSourceWriteOptions.KAFKA_AVRO_VALUE_DESERIALIZER(), "");
+    String deserializerClassName = props.getString(KAFKA_AVRO_VALUE_DESERIALIZER_OPT_KEY(), DEFAULT_KAFKA_AVRO_VALUE_DESERIALIZER_OPT_VAL());

Review comment:
       I agree with you.
   But having a way to disable the feature (setting `(hoodie.deltastreamer.source.kafka.value.deserializer.class` to empty) is always a good idea. But for this to work we need to leave in the Codeblock checking for an empty string.
   So I would suggest to leave it in regardless of the default value.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org