You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/08/10 14:59:00 UTC

[jira] [Work logged] (BEAM-10668) Replace toLowerCase().equals() with equalsIgnoreCase

     [ https://issues.apache.org/jira/browse/BEAM-10668?focusedWorklogId=468668&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-468668 ]

ASF GitHub Bot logged work on BEAM-10668:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Aug/20 14:58
            Start Date: 10/Aug/20 14:58
    Worklog Time Spent: 10m 
      Work Description: coheigea opened a new pull request #12512:
URL: https://github.com/apache/beam/pull/12512


   There are a couple of instances in the code where toLowerCase().equals() is used, when equalsIgnoreCase() would suffice. The latter is more concise + also doesn't involve the default Locale that's used with toLowerCase(), which might be problematic depending on the String being compared.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 468668)
    Remaining Estimate: 0h
            Time Spent: 10m

> Replace toLowerCase().equals() with equalsIgnoreCase
> ----------------------------------------------------
>
>                 Key: BEAM-10668
>                 URL: https://issues.apache.org/jira/browse/BEAM-10668
>             Project: Beam
>          Issue Type: Task
>          Components: sdk-java-core
>            Reporter: Colm O hEigeartaigh
>            Assignee: Colm O hEigeartaigh
>            Priority: P4
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> There are a couple of instances in the code where toLowerCase().equals() is used, when equalsIgnoreCase() would suffice. The latter is more concise + also doesn't involve the default Locale that's used with toLowerCase(), which might be problematic depending on the String being compared.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)