You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Carl Steinbach <cw...@apache.org> on 2014/02/21 22:36:53 UTC

Review Request 18377: HIVE-6481. Add .reviewboardrc file

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18377/
-----------------------------------------------------------

Review request for hive and Ashutosh Chauhan.


Bugs: HIVE-6481
    https://issues.apache.org/jira/browse/HIVE-6481


Repository: hive-git


Description
-------

HIVE-6481. Add .reviewboardrc file


Diffs
-----

  .reviewboardrc PRE-CREATION 

Diff: https://reviews.apache.org/r/18377/diff/


Testing
-------

I was able to post this review request with the command "rbt post" after committing my changes locally.


Thanks,

Carl Steinbach


Re: Review Request 18377: HIVE-6481. Add .reviewboardrc file

Posted by Carl Steinbach <cw...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18377/
-----------------------------------------------------------

(Updated Feb. 24, 2014, 6:29 p.m.)


Review request for hive and Ashutosh Chauhan.


Changes
-------

Adding ASF license header as requested.


Bugs: HIVE-6481
    https://issues.apache.org/jira/browse/HIVE-6481


Repository: hive-git


Description
-------

HIVE-6481. Add .reviewboardrc file


Diffs (updated)
-----

  .reviewboardrc PRE-CREATION 

Diff: https://reviews.apache.org/r/18377/diff/


Testing
-------

I was able to post this review request with the command "rbt post" after committing my changes locally.


Thanks,

Carl Steinbach


Re: Review Request 18377: HIVE-6481. Add .reviewboardrc file

Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18377/#review35201
-----------------------------------------------------------


Looks good. Minor question: do we need to put Apache license header for this new file?

- Xuefu Zhang


On Feb. 21, 2014, 9:36 p.m., Carl Steinbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18377/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2014, 9:36 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-6481
>     https://issues.apache.org/jira/browse/HIVE-6481
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-6481. Add .reviewboardrc file
> 
> 
> Diffs
> -----
> 
>   .reviewboardrc PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18377/diff/
> 
> 
> Testing
> -------
> 
> I was able to post this review request with the command "rbt post" after committing my changes locally.
> 
> 
> Thanks,
> 
> Carl Steinbach
> 
>