You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/07/09 03:01:21 UTC
[GitHub] [flink] cshuo opened a new pull request #16434: [FLINK-23107][table-runtime] Separate implementation of deduplicate r…
cshuo opened a new pull request #16434:
URL: https://github.com/apache/flink/pull/16434
…ank from other rank functions
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Consider the following sql:
```
SELECT *
FROM (
SELECT *, ROW_NUMBER() OVER (PARTITION BY d ORDER BY e DESC) AS rownum from T
) WHERE rownum = 1
```
It's very common for users to write the above sql to achieve the deduplication of records, but the sql cannot be translated to
`Deduplcate` when the field `e` is not time attribute field, then it'll be translated to `Rank` instead. The common implementation for rank currently is a bit of complex and error-prone.
This pr aims to separate the implementation for the deduplicate rank and reduce bugs.
## Brief change log
- Add a new rank function `FastTop1Function` for deduplicate rank
## Verifying this change
- Add unit tests for the new rank function
- Add IT case
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): yes
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16434: [FLINK-23107][table-runtime] Separate implementation of deduplicate r…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16434:
URL: https://github.com/apache/flink/pull/16434#issuecomment-876881346
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e1f1b3df1ae855ffd1be6dded31e24bdb0b1f9db",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20204",
"triggerID" : "e1f1b3df1ae855ffd1be6dded31e24bdb0b1f9db",
"triggerType" : "PUSH"
}, {
"hash" : "122a5ecbc5d48497663dee76e0d915e198aa363e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20207",
"triggerID" : "122a5ecbc5d48497663dee76e0d915e198aa363e",
"triggerType" : "PUSH"
}, {
"hash" : "bbccd2a310f51f37751deb744d480c7917cfd16e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bbccd2a310f51f37751deb744d480c7917cfd16e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 122a5ecbc5d48497663dee76e0d915e198aa363e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20207)
* bbccd2a310f51f37751deb744d480c7917cfd16e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on a change in pull request #16434: [FLINK-23107][table-runtime] Separate implementation of deduplicate r…
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #16434:
URL: https://github.com/apache/flink/pull/16434#discussion_r668394192
##########
File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/RankUtil.scala
##########
@@ -295,6 +295,11 @@ object RankUtil {
literals.head
}
+ def isTop1(rankRange: RankRange): Boolean = rankRange match {
+ case crg: ConstantRankRange => crg.getRankEnd == 1L
Review comment:
start == 1 too?
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/rank/FastTop1Function.java
##########
@@ -0,0 +1,192 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.runtime.operators.rank;
+
+import org.apache.flink.api.common.ExecutionConfig;
+import org.apache.flink.api.common.state.StateTtlConfig;
+import org.apache.flink.api.common.state.ValueState;
+import org.apache.flink.api.common.state.ValueStateDescriptor;
+import org.apache.flink.api.common.typeutils.TypeSerializer;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.runtime.state.FunctionInitializationContext;
+import org.apache.flink.runtime.state.FunctionSnapshotContext;
+import org.apache.flink.streaming.api.checkpoint.CheckpointedFunction;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.runtime.generated.GeneratedRecordComparator;
+import org.apache.flink.table.runtime.keyselector.RowDataKeySelector;
+import org.apache.flink.table.runtime.typeutils.InternalTypeInfo;
+import org.apache.flink.util.Collector;
+
+import org.apache.flink.shaded.guava18.com.google.common.cache.Cache;
+import org.apache.flink.shaded.guava18.com.google.common.cache.CacheBuilder;
+import org.apache.flink.shaded.guava18.com.google.common.cache.RemovalCause;
+import org.apache.flink.shaded.guava18.com.google.common.cache.RemovalListener;
+import org.apache.flink.shaded.guava18.com.google.common.cache.RemovalNotification;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.Map;
+import java.util.concurrent.TimeUnit;
+
+/**
+ * A more concise implementation for {@link AppendOnlyTopNFunction} and {@link
+ * UpdatableTopNFunction} when only Top-1 is desired.
Review comment:
Why it can cover updatable? We should add more comments.
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/rank/FastTop1Function.java
##########
@@ -0,0 +1,192 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.runtime.operators.rank;
+
+import org.apache.flink.api.common.ExecutionConfig;
+import org.apache.flink.api.common.state.StateTtlConfig;
+import org.apache.flink.api.common.state.ValueState;
+import org.apache.flink.api.common.state.ValueStateDescriptor;
+import org.apache.flink.api.common.typeutils.TypeSerializer;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.runtime.state.FunctionInitializationContext;
+import org.apache.flink.runtime.state.FunctionSnapshotContext;
+import org.apache.flink.streaming.api.checkpoint.CheckpointedFunction;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.runtime.generated.GeneratedRecordComparator;
+import org.apache.flink.table.runtime.keyselector.RowDataKeySelector;
+import org.apache.flink.table.runtime.typeutils.InternalTypeInfo;
+import org.apache.flink.util.Collector;
+
+import org.apache.flink.shaded.guava18.com.google.common.cache.Cache;
+import org.apache.flink.shaded.guava18.com.google.common.cache.CacheBuilder;
+import org.apache.flink.shaded.guava18.com.google.common.cache.RemovalCause;
+import org.apache.flink.shaded.guava18.com.google.common.cache.RemovalListener;
+import org.apache.flink.shaded.guava18.com.google.common.cache.RemovalNotification;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.Map;
+import java.util.concurrent.TimeUnit;
+
+/**
+ * A more concise implementation for {@link AppendOnlyTopNFunction} and {@link
+ * UpdatableTopNFunction} when only Top-1 is desired.
+ */
+public class FastTop1Function extends AbstractTopNFunction implements CheckpointedFunction {
Review comment:
ser id
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16434: [FLINK-23107][table-runtime] Separate implementation of deduplicate r…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16434:
URL: https://github.com/apache/flink/pull/16434#issuecomment-876881346
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e1f1b3df1ae855ffd1be6dded31e24bdb0b1f9db",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20204",
"triggerID" : "e1f1b3df1ae855ffd1be6dded31e24bdb0b1f9db",
"triggerType" : "PUSH"
}, {
"hash" : "122a5ecbc5d48497663dee76e0d915e198aa363e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20207",
"triggerID" : "122a5ecbc5d48497663dee76e0d915e198aa363e",
"triggerType" : "PUSH"
}, {
"hash" : "bbccd2a310f51f37751deb744d480c7917cfd16e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20361",
"triggerID" : "bbccd2a310f51f37751deb744d480c7917cfd16e",
"triggerType" : "PUSH"
}, {
"hash" : "802d88a74c0e754769dd67780fe6599753f66efc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20366",
"triggerID" : "802d88a74c0e754769dd67780fe6599753f66efc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 802d88a74c0e754769dd67780fe6599753f66efc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20366)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16434: [FLINK-23107][table-runtime] Separate implementation of deduplicate r…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16434:
URL: https://github.com/apache/flink/pull/16434#issuecomment-876881346
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e1f1b3df1ae855ffd1be6dded31e24bdb0b1f9db",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20204",
"triggerID" : "e1f1b3df1ae855ffd1be6dded31e24bdb0b1f9db",
"triggerType" : "PUSH"
}, {
"hash" : "122a5ecbc5d48497663dee76e0d915e198aa363e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20207",
"triggerID" : "122a5ecbc5d48497663dee76e0d915e198aa363e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e1f1b3df1ae855ffd1be6dded31e24bdb0b1f9db Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20204)
* 122a5ecbc5d48497663dee76e0d915e198aa363e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20207)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16434: [FLINK-23107][table-runtime] Separate implementation of deduplicate r…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16434:
URL: https://github.com/apache/flink/pull/16434#issuecomment-876877559
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 12f7fa66c5185c7a3375bf4cbd19b2df1f82a04a (Thu Sep 23 18:03:54 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16434: [FLINK-23107][table-runtime] Separate implementation of deduplicate r…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16434:
URL: https://github.com/apache/flink/pull/16434#issuecomment-876881346
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e1f1b3df1ae855ffd1be6dded31e24bdb0b1f9db",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20204",
"triggerID" : "e1f1b3df1ae855ffd1be6dded31e24bdb0b1f9db",
"triggerType" : "PUSH"
}, {
"hash" : "122a5ecbc5d48497663dee76e0d915e198aa363e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20207",
"triggerID" : "122a5ecbc5d48497663dee76e0d915e198aa363e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 122a5ecbc5d48497663dee76e0d915e198aa363e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20207)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16434: [FLINK-23107][table-runtime] Separate implementation of deduplicate r…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16434:
URL: https://github.com/apache/flink/pull/16434#issuecomment-876881346
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e1f1b3df1ae855ffd1be6dded31e24bdb0b1f9db",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20204",
"triggerID" : "e1f1b3df1ae855ffd1be6dded31e24bdb0b1f9db",
"triggerType" : "PUSH"
}, {
"hash" : "122a5ecbc5d48497663dee76e0d915e198aa363e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20207",
"triggerID" : "122a5ecbc5d48497663dee76e0d915e198aa363e",
"triggerType" : "PUSH"
}, {
"hash" : "bbccd2a310f51f37751deb744d480c7917cfd16e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20361",
"triggerID" : "bbccd2a310f51f37751deb744d480c7917cfd16e",
"triggerType" : "PUSH"
}, {
"hash" : "802d88a74c0e754769dd67780fe6599753f66efc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20366",
"triggerID" : "802d88a74c0e754769dd67780fe6599753f66efc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 122a5ecbc5d48497663dee76e0d915e198aa363e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20207)
* bbccd2a310f51f37751deb744d480c7917cfd16e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20361)
* 802d88a74c0e754769dd67780fe6599753f66efc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20366)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16434: [FLINK-23107][table-runtime] Separate implementation of deduplicate r…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16434:
URL: https://github.com/apache/flink/pull/16434#issuecomment-876881346
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e1f1b3df1ae855ffd1be6dded31e24bdb0b1f9db",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20204",
"triggerID" : "e1f1b3df1ae855ffd1be6dded31e24bdb0b1f9db",
"triggerType" : "PUSH"
}, {
"hash" : "122a5ecbc5d48497663dee76e0d915e198aa363e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20207",
"triggerID" : "122a5ecbc5d48497663dee76e0d915e198aa363e",
"triggerType" : "PUSH"
}, {
"hash" : "bbccd2a310f51f37751deb744d480c7917cfd16e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20361",
"triggerID" : "bbccd2a310f51f37751deb744d480c7917cfd16e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 122a5ecbc5d48497663dee76e0d915e198aa363e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20207)
* bbccd2a310f51f37751deb744d480c7917cfd16e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20361)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16434: [FLINK-23107][table-runtime] Separate implementation of deduplicate r…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16434:
URL: https://github.com/apache/flink/pull/16434#issuecomment-876881346
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e1f1b3df1ae855ffd1be6dded31e24bdb0b1f9db",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e1f1b3df1ae855ffd1be6dded31e24bdb0b1f9db",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e1f1b3df1ae855ffd1be6dded31e24bdb0b1f9db UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi merged pull request #16434: [FLINK-23107][table-runtime] Separate implementation of deduplicate r…
Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #16434:
URL: https://github.com/apache/flink/pull/16434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16434: [FLINK-23107][table-runtime] Separate implementation of deduplicate r…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16434:
URL: https://github.com/apache/flink/pull/16434#issuecomment-876881346
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e1f1b3df1ae855ffd1be6dded31e24bdb0b1f9db",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20204",
"triggerID" : "e1f1b3df1ae855ffd1be6dded31e24bdb0b1f9db",
"triggerType" : "PUSH"
}, {
"hash" : "122a5ecbc5d48497663dee76e0d915e198aa363e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20207",
"triggerID" : "122a5ecbc5d48497663dee76e0d915e198aa363e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e1f1b3df1ae855ffd1be6dded31e24bdb0b1f9db Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20204)
* 122a5ecbc5d48497663dee76e0d915e198aa363e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20207)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16434: [FLINK-23107][table-runtime] Separate implementation of deduplicate r…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16434:
URL: https://github.com/apache/flink/pull/16434#issuecomment-876877559
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit e1f1b3df1ae855ffd1be6dded31e24bdb0b1f9db (Fri Jul 09 03:04:26 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] cshuo commented on pull request #16434: [FLINK-23107][table-runtime] Separate implementation of deduplicate r…
Posted by GitBox <gi...@apache.org>.
cshuo commented on pull request #16434:
URL: https://github.com/apache/flink/pull/16434#issuecomment-876884044
cc @JingsongLi plz have a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] cshuo commented on a change in pull request #16434: [FLINK-23107][table-runtime] Separate implementation of deduplicate r…
Posted by GitBox <gi...@apache.org>.
cshuo commented on a change in pull request #16434:
URL: https://github.com/apache/flink/pull/16434#discussion_r666640410
##########
File path: flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/operators/rank/FastTop1FunctionTest.java
##########
@@ -0,0 +1,181 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.runtime.operators.rank;
+
+import org.apache.flink.runtime.checkpoint.OperatorSubtaskState;
+import org.apache.flink.streaming.util.OneInputStreamOperatorTestHarness;
+import org.apache.flink.table.data.RowData;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import static org.apache.flink.table.runtime.util.StreamRecordUtils.insertRecord;
+import static org.apache.flink.table.runtime.util.StreamRecordUtils.updateAfterRecord;
+import static org.apache.flink.table.runtime.util.StreamRecordUtils.updateBeforeRecord;
+
+/** Tests for {@link FastTop1Function}. */
Review comment:
...will add some more tests with UPDATE inputs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16434: [FLINK-23107][table-runtime] Separate implementation of deduplicate r…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16434:
URL: https://github.com/apache/flink/pull/16434#issuecomment-876881346
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e1f1b3df1ae855ffd1be6dded31e24bdb0b1f9db",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20204",
"triggerID" : "e1f1b3df1ae855ffd1be6dded31e24bdb0b1f9db",
"triggerType" : "PUSH"
}, {
"hash" : "122a5ecbc5d48497663dee76e0d915e198aa363e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "122a5ecbc5d48497663dee76e0d915e198aa363e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e1f1b3df1ae855ffd1be6dded31e24bdb0b1f9db Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20204)
* 122a5ecbc5d48497663dee76e0d915e198aa363e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16434: [FLINK-23107][table-runtime] Separate implementation of deduplicate r…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16434:
URL: https://github.com/apache/flink/pull/16434#issuecomment-876881346
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e1f1b3df1ae855ffd1be6dded31e24bdb0b1f9db",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20204",
"triggerID" : "e1f1b3df1ae855ffd1be6dded31e24bdb0b1f9db",
"triggerType" : "PUSH"
}, {
"hash" : "122a5ecbc5d48497663dee76e0d915e198aa363e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20207",
"triggerID" : "122a5ecbc5d48497663dee76e0d915e198aa363e",
"triggerType" : "PUSH"
}, {
"hash" : "bbccd2a310f51f37751deb744d480c7917cfd16e",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20361",
"triggerID" : "bbccd2a310f51f37751deb744d480c7917cfd16e",
"triggerType" : "PUSH"
}, {
"hash" : "802d88a74c0e754769dd67780fe6599753f66efc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20366",
"triggerID" : "802d88a74c0e754769dd67780fe6599753f66efc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bbccd2a310f51f37751deb744d480c7917cfd16e Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20361)
* 802d88a74c0e754769dd67780fe6599753f66efc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20366)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16434: [FLINK-23107][table-runtime] Separate implementation of deduplicate r…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16434:
URL: https://github.com/apache/flink/pull/16434#issuecomment-876881346
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e1f1b3df1ae855ffd1be6dded31e24bdb0b1f9db",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20204",
"triggerID" : "e1f1b3df1ae855ffd1be6dded31e24bdb0b1f9db",
"triggerType" : "PUSH"
}, {
"hash" : "122a5ecbc5d48497663dee76e0d915e198aa363e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20207",
"triggerID" : "122a5ecbc5d48497663dee76e0d915e198aa363e",
"triggerType" : "PUSH"
}, {
"hash" : "bbccd2a310f51f37751deb744d480c7917cfd16e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20361",
"triggerID" : "bbccd2a310f51f37751deb744d480c7917cfd16e",
"triggerType" : "PUSH"
}, {
"hash" : "802d88a74c0e754769dd67780fe6599753f66efc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20366",
"triggerID" : "802d88a74c0e754769dd67780fe6599753f66efc",
"triggerType" : "PUSH"
}, {
"hash" : "12f7fa66c5185c7a3375bf4cbd19b2df1f82a04a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "12f7fa66c5185c7a3375bf4cbd19b2df1f82a04a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 802d88a74c0e754769dd67780fe6599753f66efc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20366)
* 12f7fa66c5185c7a3375bf4cbd19b2df1f82a04a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on a change in pull request #16434: [FLINK-23107][table-runtime] Separate implementation of deduplicate r…
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #16434:
URL: https://github.com/apache/flink/pull/16434#discussion_r668571926
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/rank/FastTop1Function.java
##########
@@ -0,0 +1,196 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.runtime.operators.rank;
+
+import org.apache.flink.api.common.ExecutionConfig;
+import org.apache.flink.api.common.state.StateTtlConfig;
+import org.apache.flink.api.common.state.ValueState;
+import org.apache.flink.api.common.state.ValueStateDescriptor;
+import org.apache.flink.api.common.typeutils.TypeSerializer;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.runtime.state.FunctionInitializationContext;
+import org.apache.flink.runtime.state.FunctionSnapshotContext;
+import org.apache.flink.streaming.api.checkpoint.CheckpointedFunction;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.runtime.generated.GeneratedRecordComparator;
+import org.apache.flink.table.runtime.keyselector.RowDataKeySelector;
+import org.apache.flink.table.runtime.typeutils.InternalTypeInfo;
+import org.apache.flink.util.Collector;
+
+import org.apache.flink.shaded.guava18.com.google.common.cache.Cache;
+import org.apache.flink.shaded.guava18.com.google.common.cache.CacheBuilder;
+import org.apache.flink.shaded.guava18.com.google.common.cache.RemovalCause;
+import org.apache.flink.shaded.guava18.com.google.common.cache.RemovalListener;
+import org.apache.flink.shaded.guava18.com.google.common.cache.RemovalNotification;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.Map;
+import java.util.concurrent.TimeUnit;
+
+/**
+ * A more concise implementation for {@link AppendOnlyTopNFunction} and {@link
+ * UpdatableTopNFunction} when only Top-1 is desired. This function can handle updating stream
+ * because the RankProcessStrategy is inferred as UpdateFastStrategy, i.e., 1) the upsert key of
+ * input steam contains partition key; 2) the sort field is updated monotonely under the upsert key.
+ */
+public class FastTop1Function extends AbstractTopNFunction implements CheckpointedFunction {
+
+ private static final long serialVersionUID = -1379466658843676156L;
Review comment:
serialVersionUID should start with 1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16434: [FLINK-23107][table-runtime] Separate implementation of deduplicate r…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16434:
URL: https://github.com/apache/flink/pull/16434#issuecomment-876881346
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e1f1b3df1ae855ffd1be6dded31e24bdb0b1f9db",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20204",
"triggerID" : "e1f1b3df1ae855ffd1be6dded31e24bdb0b1f9db",
"triggerType" : "PUSH"
}, {
"hash" : "122a5ecbc5d48497663dee76e0d915e198aa363e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20207",
"triggerID" : "122a5ecbc5d48497663dee76e0d915e198aa363e",
"triggerType" : "PUSH"
}, {
"hash" : "bbccd2a310f51f37751deb744d480c7917cfd16e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20361",
"triggerID" : "bbccd2a310f51f37751deb744d480c7917cfd16e",
"triggerType" : "PUSH"
}, {
"hash" : "802d88a74c0e754769dd67780fe6599753f66efc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20366",
"triggerID" : "802d88a74c0e754769dd67780fe6599753f66efc",
"triggerType" : "PUSH"
}, {
"hash" : "12f7fa66c5185c7a3375bf4cbd19b2df1f82a04a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20460",
"triggerID" : "12f7fa66c5185c7a3375bf4cbd19b2df1f82a04a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 12f7fa66c5185c7a3375bf4cbd19b2df1f82a04a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20460)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16434: [FLINK-23107][table-runtime] Separate implementation of deduplicate r…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16434:
URL: https://github.com/apache/flink/pull/16434#issuecomment-876881346
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e1f1b3df1ae855ffd1be6dded31e24bdb0b1f9db",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20204",
"triggerID" : "e1f1b3df1ae855ffd1be6dded31e24bdb0b1f9db",
"triggerType" : "PUSH"
}, {
"hash" : "122a5ecbc5d48497663dee76e0d915e198aa363e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20207",
"triggerID" : "122a5ecbc5d48497663dee76e0d915e198aa363e",
"triggerType" : "PUSH"
}, {
"hash" : "bbccd2a310f51f37751deb744d480c7917cfd16e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20361",
"triggerID" : "bbccd2a310f51f37751deb744d480c7917cfd16e",
"triggerType" : "PUSH"
}, {
"hash" : "802d88a74c0e754769dd67780fe6599753f66efc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20366",
"triggerID" : "802d88a74c0e754769dd67780fe6599753f66efc",
"triggerType" : "PUSH"
}, {
"hash" : "12f7fa66c5185c7a3375bf4cbd19b2df1f82a04a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20460",
"triggerID" : "12f7fa66c5185c7a3375bf4cbd19b2df1f82a04a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 802d88a74c0e754769dd67780fe6599753f66efc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20366)
* 12f7fa66c5185c7a3375bf4cbd19b2df1f82a04a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20460)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16434: [FLINK-23107][table-runtime] Separate implementation of deduplicate r…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16434:
URL: https://github.com/apache/flink/pull/16434#issuecomment-876881346
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e1f1b3df1ae855ffd1be6dded31e24bdb0b1f9db",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20204",
"triggerID" : "e1f1b3df1ae855ffd1be6dded31e24bdb0b1f9db",
"triggerType" : "PUSH"
}, {
"hash" : "122a5ecbc5d48497663dee76e0d915e198aa363e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20207",
"triggerID" : "122a5ecbc5d48497663dee76e0d915e198aa363e",
"triggerType" : "PUSH"
}, {
"hash" : "bbccd2a310f51f37751deb744d480c7917cfd16e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20361",
"triggerID" : "bbccd2a310f51f37751deb744d480c7917cfd16e",
"triggerType" : "PUSH"
}, {
"hash" : "802d88a74c0e754769dd67780fe6599753f66efc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "802d88a74c0e754769dd67780fe6599753f66efc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 122a5ecbc5d48497663dee76e0d915e198aa363e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20207)
* bbccd2a310f51f37751deb744d480c7917cfd16e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20361)
* 802d88a74c0e754769dd67780fe6599753f66efc UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org