You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dolphinscheduler.apache.org by Jave-Chen <ke...@foxmail.com> on 2020/07/08 14:22:21 UTC
RE：[Vote] Pull Request Title Specification
A PR may be associated with multiple issues, so writing Issue No. in PR titile may
be miscellaneous.
------------------ 原始邮件 ------------------
发件人: "Yichao Yang"<1048262223@qq.com>;
发送时间: 2020年7月8日(星期三) 晚上9:29
收件人: "dev"<dev@dolphinscheduler.apache.org>;
主题: [Vote] Pull Request Title Specification
Hi all,
After referring to the practices of other open source communities on the title of pull request, we propose two pre selection schemes for dolphin scheduler.
First：
Specification:
[`Open Source Project Name`-`Issue No`][`Module Name`] `Pull Request Description`
example：
[DS-3333][server] Fix the xxx exception
[DS-3333][server] Implement xxx
...
Second：
Specification:
[`Pull Request Type`-`Issue No`][`Module Name`] `Pull Request Description`
example：
[Fix-3333][server] Fix the xxx exception
[Feature-3333][server] Implement xxx
...
The Pull Request type is shown in the screenshot in [1].
If you agree with the first one as the title of the pull request, reply 1, and the second one reply 2. If there is no other suggestions after 7 days, we will choose the first one.
--------------------------------------------------------
目前参考了其他开源社区的对于 Pull Request 标题的实践之后，针对 DolphinScheduler 我们提出了两种预选的方案：
第一种：
Specification:
[`Open Source Project Name`-`Issue No`][`Module Name`] `Pull Request Description`
example：
[DS-3333][server] Fix the xxx exception
[DS-3333][server] Implement xxx
...
第二种：
Specification:
[`Pull Request Type`-`Issue No`][`Module Name`] `Pull Request Description`
example：
[Fix-3333][server] Fix the xxx exception
[Feature-3333][server] Implement xxx
...
Pull Request Type 类型在 [1] 中截图给出。
如果想选第一种作为Pull request 标题，则回复1，第二种则回复2。没有其他意见或者建议的话，7天之后默认以第一种作为 Pull Request 规范。
[1] Pull Request Type: https://github.com/apache/incubator-dolphinscheduler-website/pull/147
Best,
Yichao Yang
Re: [Vote] Pull Request Title Specification
Posted by CalvinKirs <ac...@163.com>.
Hello, I personally think that repeated issues need to be closed, he will cause us to have multiple copies, and also need to spend extra energy to maintain multiple issues, in addition, if the big pr is disassembled, (provided that each sub-item Do not affect each other), if it can not be disassembled, it is recommended to summarize an issue. We always hope to solve the problem with the smallest granularity. This will be very easy for developers and reviewers
| |
Kirs
|
|
邮箱：acm_master@163.com
|
Signature is customized by Netease Mail Master
On 07/09/2020 07:29, Jave-Chen wrote:
On one hand, since everyone is free to create issues, different users may create
issues for the same reason.
On the other hand, spliting a large PR into multiple small PRs requires developers
to read all prs, would it be inappropriate ？
------------------ 原始邮件 ------------------
发件人: "CalvinKirs"<acm_master@163.com>;
发送时间: 2020年7月9日(星期四) 凌晨2:02
收件人: "dev@dolphinscheduler.apache.org"<dev@dolphinscheduler.apache.org>;
主题: Re:[Vote] Pull Request Title Specification
Hi, I think this is a question worthy of recognition. I think our big pr should be separated, corresponding to an isuess, if it cannot be split, can it be aggregated into an isuess，how do you think？If I am wrong, please correct me
Best regards！
CalvinKirs
On 07/8/2020 22:22，Jave-Chen<kejia.chen@foxmail.com> wrote：
A PR may be associated with multiple issues, so writing Issue No. in PR titile may&nbsp;
be miscellaneous.
------------------&nbsp;原始邮件&nbsp;------------------
发件人:&nbsp;"Yichao Yang"<1048262223@qq.com&gt;;
发送时间:&nbsp;2020年7月8日(星期三) 晚上9:29
收件人:&nbsp;"dev"<dev@dolphinscheduler.apache.org&gt;;
主题:&nbsp;[Vote] Pull Request Title Specification
Hi all,
After referring to the practices of other open source communities on the title of pull request, we propose two pre selection schemes for dolphin scheduler.
First：
Specification:
[`Open Source Project Name`-`Issue No`][`Module Name`] `Pull Request Description`
example：
[DS-3333][server] Fix the xxx exception
[DS-3333][server] Implement xxx
...
Second：
Specification:
[`Pull Request Type`-`Issue No`][`Module Name`] `Pull Request Description`
example：
[Fix-3333][server] Fix the xxx exception
[Feature-3333][server] Implement xxx
...
The Pull Request type is shown in the screenshot in [1].
If you agree with the first one as the title of the pull request, reply 1, and the second one reply 2. If there is no other suggestions after 7 days, we will choose the first one.
--------------------------------------------------------
目前参考了其他开源社区的对于 Pull Request 标题的实践之后，针对 DolphinScheduler 我们提出了两种预选的方案：
第一种：
Specification:
[`Open Source Project Name`-`Issue No`][`Module Name`] `Pull Request Description`
example：
[DS-3333][server] Fix the xxx exception
[DS-3333][server] Implement xxx
...
第二种：
Specification:
[`Pull Request Type`-`Issue No`][`Module Name`] `Pull Request Description`
example：
[Fix-3333][server] Fix the xxx exception
[Feature-3333][server] Implement xxx
...
Pull Request Type 类型在 [1] 中截图给出。
如果想选第一种作为Pull request 标题，则回复1，第二种则回复2。没有其他意见或者建议的话，7天之后默认以第一种作为 Pull Request 规范。
[1] Pull Request Type: https://github.com/apache/incubator-dolphinscheduler-website/pull/147
Best,
Yichao Yang
Re: Re： [Vote] Pull Request Title Specification
Posted by lidong dai <da...@gmail.com>.
2
Best Regards
---------------
DolphinScheduler(Incubator) PPMC
Lidong Dai 代立冬
dailidong66@gmail.com
---------------
wu shaoj <ga...@apache.org> 于2020年7月9日周四 下午2:24写道：
> 2
>
> On 2020/7/9, 14:20, "Yichao Yang" <10...@qq.com> wrote:
>
> 2
>
>
>
>
> ------------------ 原始邮件 ------------------
> 发件人: "JUN GAO"<gaojun2048@gmail.com>;
> 发送时间: 2020年7月9日(星期四) 中午11:42
> 收件人: "dev"<dev@dolphinscheduler.apache.org>;
>
> 主题: Re: [Vote] Pull Request Title Specification
>
>
>
> 2
>
> It is necessary to split large pr into small pr.
> I agree with the second option.
>
>
> Jave-Chen <kejia.chen@foxmail.com> 于2020年7月9日周四 上午7:30写道：
>
> > On one hand, since everyone is free to create
> issues,&nbsp;different users
> > may create&nbsp;
> > issues for the same reason.
> >
> >
> >
> > On the other hand,&nbsp;spliting a large PR
> into&nbsp;multiple small PRs
> > requires developers&nbsp;
> > to read all prs, would it be inappropriate ？
> >
> >
> >
> >
> > ------------------&nbsp;原始邮件&nbsp;------------------
> > 发件人:&nbsp;"CalvinKirs"<acm_master@163.com&gt;;
> > 发送时间:&nbsp;2020年7月9日(星期四) 凌晨2:02
> > 收件人:&nbsp;"dev@dolphinscheduler.apache.org"<
> > dev@dolphinscheduler.apache.org&gt;;
> >
> > 主题:&nbsp;Re:[Vote] Pull Request Title Specification
> >
> >
> >
> > Hi, I think this is a question worthy of recognition.&nbsp; I
> think our
> > big pr should be separated, corresponding to an isuess, if it
> cannot be
> > split, can it be aggregated into an isuess，how do you think？If I
> am wrong,
> > please correct me
> >
> >
> > Best regards！
> > CalvinKirs
> >
> >
> > On 07/8/2020 22:22，Jave-Chen<kejia.chen@foxmail.com&gt;
> wrote：
> > A PR may be associated with multiple issues, so writing Issue No.
> in PR
> > titile may&amp;nbsp;
> > be miscellaneous.
> >
> >
> >
> >
> ------------------&amp;nbsp;原始邮件&amp;nbsp;------------------
> > 发件人:&amp;nbsp;"Yichao Yang"<1048262223@qq.com&amp;gt;;
> > 发送时间:&amp;nbsp;2020年7月8日(星期三) 晚上9:29
> > 收件人:&amp;nbsp;"dev"<dev@dolphinscheduler.apache.org
> &amp;gt;;
> >
> > 主题:&amp;nbsp;[Vote] Pull Request Title Specification
> >
> >
> >
> > Hi all,
> >
> >
> > After referring to the practices of other open source communities
> on the
> > title of pull request, we propose two pre selection schemes for
> dolphin
> > scheduler.
> >
> >
> > First：
> >
> > Specification:
> >
> > [`Open Source Project Name`-`Issue No`][`Module Name`] `Pull
> Request
> > Description`
> >
> > example：
> >
> > [DS-3333][server] Fix the xxx exception
> >
> > [DS-3333][server] Implement xxx
> >
> > ...
> >
> >
> >
> >
> > Second：
> >
> > Specification:
> >
> > [`Pull Request Type`-`Issue No`][`Module Name`] `Pull Request
> Description`
> >
> > example：
> >
> > [Fix-3333][server] Fix the xxx exception
> >
> > [Feature-3333][server] Implement xxx
> >
> > ...
> >
> > The Pull Request type is shown in the screenshot in [1].
> >
> >
> >
> >
> > If you agree with the first one as the title of the pull request,
> reply 1,
> > and the second one reply 2. If there is no other suggestions
> after 7 days,
> > we will choose the first one.
> >
> >
> >
> >
> > --------------------------------------------------------
> >
> >
> >
> >
> > 目前参考了其他开源社区的对于 Pull Request 标题的实践之后，针对 DolphinScheduler
> 我们提出了两种预选的方案：
> >
> >
> > 第一种：
> >
> > Specification:
> >
> > [`Open Source Project Name`-`Issue No`][`Module Name`] `Pull
> Request
> > Description`
> >
> > example：
> >
> > [DS-3333][server] Fix the xxx exception
> >
> > [DS-3333][server] Implement xxx
> >
> > ...
> >
> >
> >
> >
> > 第二种：
> >
> > Specification:
> >
> > [`Pull Request Type`-`Issue No`][`Module Name`] `Pull Request
> Description`
> >
> > example：
> >
> > [Fix-3333][server] Fix the xxx exception
> >
> > [Feature-3333][server] Implement xxx
> >
> > ...
> >
> > Pull Request Type 类型在 [1] 中截图给出。
> >
> >
> >
> >
> > 如果想选第一种作为Pull request 标题，则回复1，第二种则回复2。没有其他意见或者建议的话，7天之后默认以第一种作为
> Pull
> > Request 规范。
> >
> >
> >
> >
> > [1] Pull Request Type:
> >
> https://github.com/apache/incubator-dolphinscheduler-website/pull/147
> >
> >
> >
> >
> > Best,
> >
> > Yichao Yang
>
>
>
> --
>
> DolphinScheduler(Incubator) PPMC
> Jun Gao 高俊
> gaojun2048@gmail.com
>
Re: Re： [Vote] Pull Request Title Specification
Posted by wu shaoj <ga...@apache.org>.
2
On 2020/7/9, 14:20, "Yichao Yang" <10...@qq.com> wrote:
2
------------------ 原始邮件 ------------------
发件人: "JUN GAO"<gaojun2048@gmail.com>;
发送时间: 2020年7月9日(星期四) 中午11:42
收件人: "dev"<dev@dolphinscheduler.apache.org>;
主题: Re: [Vote] Pull Request Title Specification
2
It is necessary to split large pr into small pr.
I agree with the second option.
Jave-Chen <kejia.chen@foxmail.com> 于2020年7月9日周四 上午7:30写道：
> On one hand, since everyone is free to create issues,&nbsp;different users
> may create&nbsp;
> issues for the same reason.
>
>
>
> On the other hand,&nbsp;spliting a large PR into&nbsp;multiple small PRs
> requires developers&nbsp;
> to read all prs, would it be inappropriate ？
>
>
>
>
> ------------------&nbsp;原始邮件&nbsp;------------------
> 发件人:&nbsp;"CalvinKirs"<acm_master@163.com&gt;;
> 发送时间:&nbsp;2020年7月9日(星期四) 凌晨2:02
> 收件人:&nbsp;"dev@dolphinscheduler.apache.org"<
> dev@dolphinscheduler.apache.org&gt;;
>
> 主题:&nbsp;Re:[Vote] Pull Request Title Specification
>
>
>
> Hi, I think this is a question worthy of recognition.&nbsp; I think our
> big pr should be separated, corresponding to an isuess, if it cannot be
> split, can it be aggregated into an isuess，how do you think？If I am wrong,
> please correct me
>
>
> Best regards！
> CalvinKirs
>
>
> On 07/8/2020 22:22，Jave-Chen<kejia.chen@foxmail.com&gt; wrote：
> A PR may be associated with multiple issues, so writing Issue No. in PR
> titile may&amp;nbsp;
> be miscellaneous.
>
>
>
> ------------------&amp;nbsp;原始邮件&amp;nbsp;------------------
> 发件人:&amp;nbsp;"Yichao Yang"<1048262223@qq.com&amp;gt;;
> 发送时间:&amp;nbsp;2020年7月8日(星期三) 晚上9:29
> 收件人:&amp;nbsp;"dev"<dev@dolphinscheduler.apache.org&amp;gt;;
>
> 主题:&amp;nbsp;[Vote] Pull Request Title Specification
>
>
>
> Hi all,
>
>
> After referring to the practices of other open source communities on the
> title of pull request, we propose two pre selection schemes for dolphin
> scheduler.
>
>
> First：
>
> Specification:
>
> [`Open Source Project Name`-`Issue No`][`Module Name`] `Pull Request
> Description`
>
> example：
>
> [DS-3333][server] Fix the xxx exception
>
> [DS-3333][server] Implement xxx
>
> ...
>
>
>
>
> Second：
>
> Specification:
>
> [`Pull Request Type`-`Issue No`][`Module Name`] `Pull Request Description`
>
> example：
>
> [Fix-3333][server] Fix the xxx exception
>
> [Feature-3333][server] Implement xxx
>
> ...
>
> The Pull Request type is shown in the screenshot in [1].
>
>
>
>
> If you agree with the first one as the title of the pull request, reply 1,
> and the second one reply 2. If there is no other suggestions after 7 days,
> we will choose the first one.
>
>
>
>
> --------------------------------------------------------
>
>
>
>
> 目前参考了其他开源社区的对于 Pull Request 标题的实践之后，针对 DolphinScheduler 我们提出了两种预选的方案：
>
>
> 第一种：
>
> Specification:
>
> [`Open Source Project Name`-`Issue No`][`Module Name`] `Pull Request
> Description`
>
> example：
>
> [DS-3333][server] Fix the xxx exception
>
> [DS-3333][server] Implement xxx
>
> ...
>
>
>
>
> 第二种：
>
> Specification:
>
> [`Pull Request Type`-`Issue No`][`Module Name`] `Pull Request Description`
>
> example：
>
> [Fix-3333][server] Fix the xxx exception
>
> [Feature-3333][server] Implement xxx
>
> ...
>
> Pull Request Type 类型在 [1] 中截图给出。
>
>
>
>
> 如果想选第一种作为Pull request 标题，则回复1，第二种则回复2。没有其他意见或者建议的话，7天之后默认以第一种作为 Pull
> Request 规范。
>
>
>
>
> [1] Pull Request Type:
> https://github.com/apache/incubator-dolphinscheduler-website/pull/147
>
>
>
>
> Best,
>
> Yichao Yang
--
DolphinScheduler(Incubator) PPMC
Jun Gao 高俊
gaojun2048@gmail.com
Re： [Vote] Pull Request Title Specification
Posted by Yichao Yang <10...@qq.com>.
2
------------------ 原始邮件 ------------------
发件人: "JUN GAO"<gaojun2048@gmail.com>;
发送时间: 2020年7月9日(星期四) 中午11:42
收件人: "dev"<dev@dolphinscheduler.apache.org>;
主题: Re: [Vote] Pull Request Title Specification
2
It is necessary to split large pr into small pr.
I agree with the second option.
Jave-Chen <kejia.chen@foxmail.com> 于2020年7月9日周四 上午7:30写道：
> On one hand, since everyone is free to create issues,&nbsp;different users
> may create&nbsp;
> issues for the same reason.
>
>
>
> On the other hand,&nbsp;spliting a large PR into&nbsp;multiple small PRs
> requires developers&nbsp;
> to read all prs, would it be inappropriate ？
>
>
>
>
> ------------------&nbsp;原始邮件&nbsp;------------------
> 发件人:&nbsp;"CalvinKirs"<acm_master@163.com&gt;;
> 发送时间:&nbsp;2020年7月9日(星期四) 凌晨2:02
> 收件人:&nbsp;"dev@dolphinscheduler.apache.org"<
> dev@dolphinscheduler.apache.org&gt;;
>
> 主题:&nbsp;Re:[Vote] Pull Request Title Specification
>
>
>
> Hi, I think this is a question worthy of recognition.&nbsp; I think our
> big pr should be separated, corresponding to an isuess, if it cannot be
> split, can it be aggregated into an isuess，how do you think？If I am wrong,
> please correct me
>
>
> Best regards！
> CalvinKirs
>
>
> On 07/8/2020 22:22，Jave-Chen<kejia.chen@foxmail.com&gt; wrote：
> A PR may be associated with multiple issues, so writing Issue No. in PR
> titile may&amp;nbsp;
> be miscellaneous.
>
>
>
> ------------------&amp;nbsp;原始邮件&amp;nbsp;------------------
> 发件人:&amp;nbsp;"Yichao Yang"<1048262223@qq.com&amp;gt;;
> 发送时间:&amp;nbsp;2020年7月8日(星期三) 晚上9:29
> 收件人:&amp;nbsp;"dev"<dev@dolphinscheduler.apache.org&amp;gt;;
>
> 主题:&amp;nbsp;[Vote] Pull Request Title Specification
>
>
>
> Hi all,
>
>
> After referring to the practices of other open source communities on the
> title of pull request, we propose two pre selection schemes for dolphin
> scheduler.
>
>
> First：
>
> Specification:
>
> [`Open Source Project Name`-`Issue No`][`Module Name`] `Pull Request
> Description`
>
> example：
>
> [DS-3333][server] Fix the xxx exception
>
> [DS-3333][server] Implement xxx
>
> ...
>
>
>
>
> Second：
>
> Specification:
>
> [`Pull Request Type`-`Issue No`][`Module Name`] `Pull Request Description`
>
> example：
>
> [Fix-3333][server] Fix the xxx exception
>
> [Feature-3333][server] Implement xxx
>
> ...
>
> The Pull Request type is shown in the screenshot in [1].
>
>
>
>
> If you agree with the first one as the title of the pull request, reply 1,
> and the second one reply 2. If there is no other suggestions after 7 days,
> we will choose the first one.
>
>
>
>
> --------------------------------------------------------
>
>
>
>
> 目前参考了其他开源社区的对于 Pull Request 标题的实践之后，针对 DolphinScheduler 我们提出了两种预选的方案：
>
>
> 第一种：
>
> Specification:
>
> [`Open Source Project Name`-`Issue No`][`Module Name`] `Pull Request
> Description`
>
> example：
>
> [DS-3333][server] Fix the xxx exception
>
> [DS-3333][server] Implement xxx
>
> ...
>
>
>
>
> 第二种：
>
> Specification:
>
> [`Pull Request Type`-`Issue No`][`Module Name`] `Pull Request Description`
>
> example：
>
> [Fix-3333][server] Fix the xxx exception
>
> [Feature-3333][server] Implement xxx
>
> ...
>
> Pull Request Type 类型在 [1] 中截图给出。
>
>
>
>
> 如果想选第一种作为Pull request 标题，则回复1，第二种则回复2。没有其他意见或者建议的话，7天之后默认以第一种作为 Pull
> Request 规范。
>
>
>
>
> [1] Pull Request Type:
> https://github.com/apache/incubator-dolphinscheduler-website/pull/147
>
>
>
>
> Best,
>
> Yichao Yang
--
DolphinScheduler(Incubator) PPMC
Jun Gao 高俊
gaojun2048@gmail.com
Re: [Vote] Pull Request Title Specification
Posted by JUN GAO <ga...@gmail.com>.
2
It is necessary to split large pr into small pr.
I agree with the second option.
Jave-Chen <ke...@foxmail.com> 于2020年7月9日周四 上午7:30写道：
> On one hand, since everyone is free to create issues, different users
> may create
> issues for the same reason.
>
>
>
> On the other hand, spliting a large PR into multiple small PRs
> requires developers
> to read all prs, would it be inappropriate ？
>
>
>
>
> ------------------ 原始邮件 ------------------
> 发件人: "CalvinKirs"<acm_master@163.com>;
> 发送时间: 2020年7月9日(星期四) 凌晨2:02
> 收件人: "dev@dolphinscheduler.apache.org"<
> dev@dolphinscheduler.apache.org>;
>
> 主题: Re:[Vote] Pull Request Title Specification
>
>
>
> Hi, I think this is a question worthy of recognition. I think our
> big pr should be separated, corresponding to an isuess, if it cannot be
> split, can it be aggregated into an isuess，how do you think？If I am wrong,
> please correct me
>
>
> Best regards！
> CalvinKirs
>
>
> On 07/8/2020 22:22，Jave-Chen<kejia.chen@foxmail.com> wrote：
> A PR may be associated with multiple issues, so writing Issue No. in PR
> titile may&nbsp;
> be miscellaneous.
>
>
>
> ------------------&nbsp;原始邮件&nbsp;------------------
> 发件人:&nbsp;"Yichao Yang"<1048262223@qq.com&gt;;
> 发送时间:&nbsp;2020年7月8日(星期三) 晚上9:29
> 收件人:&nbsp;"dev"<dev@dolphinscheduler.apache.org&gt;;
>
> 主题:&nbsp;[Vote] Pull Request Title Specification
>
>
>
> Hi all,
>
>
> After referring to the practices of other open source communities on the
> title of pull request, we propose two pre selection schemes for dolphin
> scheduler.
>
>
> First：
>
> Specification:
>
> [`Open Source Project Name`-`Issue No`][`Module Name`] `Pull Request
> Description`
>
> example：
>
> [DS-3333][server] Fix the xxx exception
>
> [DS-3333][server] Implement xxx
>
> ...
>
>
>
>
> Second：
>
> Specification:
>
> [`Pull Request Type`-`Issue No`][`Module Name`] `Pull Request Description`
>
> example：
>
> [Fix-3333][server] Fix the xxx exception
>
> [Feature-3333][server] Implement xxx
>
> ...
>
> The Pull Request type is shown in the screenshot in [1].
>
>
>
>
> If you agree with the first one as the title of the pull request, reply 1,
> and the second one reply 2. If there is no other suggestions after 7 days,
> we will choose the first one.
>
>
>
>
> --------------------------------------------------------
>
>
>
>
> 目前参考了其他开源社区的对于 Pull Request 标题的实践之后，针对 DolphinScheduler 我们提出了两种预选的方案：
>
>
> 第一种：
>
> Specification:
>
> [`Open Source Project Name`-`Issue No`][`Module Name`] `Pull Request
> Description`
>
> example：
>
> [DS-3333][server] Fix the xxx exception
>
> [DS-3333][server] Implement xxx
>
> ...
>
>
>
>
> 第二种：
>
> Specification:
>
> [`Pull Request Type`-`Issue No`][`Module Name`] `Pull Request Description`
>
> example：
>
> [Fix-3333][server] Fix the xxx exception
>
> [Feature-3333][server] Implement xxx
>
> ...
>
> Pull Request Type 类型在 [1] 中截图给出。
>
>
>
>
> 如果想选第一种作为Pull request 标题，则回复1，第二种则回复2。没有其他意见或者建议的话，7天之后默认以第一种作为 Pull
> Request 规范。
>
>
>
>
> [1] Pull Request Type:
> https://github.com/apache/incubator-dolphinscheduler-website/pull/147
>
>
>
>
> Best,
>
> Yichao Yang
--
DolphinScheduler(Incubator) PPMC
Jun Gao 高俊
gaojun2048@gmail.com
RE：[Vote] Pull Request Title Specification
Posted by Jave-Chen <ke...@foxmail.com>.
On one hand, since everyone is free to create issues, different users may create
issues for the same reason.
On the other hand, spliting a large PR into multiple small PRs requires developers
to read all prs, would it be inappropriate ？
------------------ 原始邮件 ------------------
发件人: "CalvinKirs"<acm_master@163.com>;
发送时间: 2020年7月9日(星期四) 凌晨2:02
收件人: "dev@dolphinscheduler.apache.org"<dev@dolphinscheduler.apache.org>;
主题: Re:[Vote] Pull Request Title Specification
Hi, I think this is a question worthy of recognition. I think our big pr should be separated, corresponding to an isuess, if it cannot be split, can it be aggregated into an isuess，how do you think？If I am wrong, please correct me
Best regards！
CalvinKirs
On 07/8/2020 22:22，Jave-Chen<kejia.chen@foxmail.com> wrote：
A PR may be associated with multiple issues, so writing Issue No. in PR titile may&nbsp;
be miscellaneous.
------------------&nbsp;原始邮件&nbsp;------------------
发件人:&nbsp;"Yichao Yang"<1048262223@qq.com&gt;;
发送时间:&nbsp;2020年7月8日(星期三) 晚上9:29
收件人:&nbsp;"dev"<dev@dolphinscheduler.apache.org&gt;;
主题:&nbsp;[Vote] Pull Request Title Specification
Hi all,
After referring to the practices of other open source communities on the title of pull request, we propose two pre selection schemes for dolphin scheduler.
First：
Specification:
[`Open Source Project Name`-`Issue No`][`Module Name`] `Pull Request Description`
example：
[DS-3333][server] Fix the xxx exception
[DS-3333][server] Implement xxx
...
Second：
Specification:
[`Pull Request Type`-`Issue No`][`Module Name`] `Pull Request Description`
example：
[Fix-3333][server] Fix the xxx exception
[Feature-3333][server] Implement xxx
...
The Pull Request type is shown in the screenshot in [1].
If you agree with the first one as the title of the pull request, reply 1, and the second one reply 2. If there is no other suggestions after 7 days, we will choose the first one.
--------------------------------------------------------
目前参考了其他开源社区的对于 Pull Request 标题的实践之后，针对 DolphinScheduler 我们提出了两种预选的方案：
第一种：
Specification:
[`Open Source Project Name`-`Issue No`][`Module Name`] `Pull Request Description`
example：
[DS-3333][server] Fix the xxx exception
[DS-3333][server] Implement xxx
...
第二种：
Specification:
[`Pull Request Type`-`Issue No`][`Module Name`] `Pull Request Description`
example：
[Fix-3333][server] Fix the xxx exception
[Feature-3333][server] Implement xxx
...
Pull Request Type 类型在 [1] 中截图给出。
如果想选第一种作为Pull request 标题，则回复1，第二种则回复2。没有其他意见或者建议的话，7天之后默认以第一种作为 Pull Request 规范。
[1] Pull Request Type: https://github.com/apache/incubator-dolphinscheduler-website/pull/147
Best,
Yichao Yang
Re:[Vote] Pull Request Title Specification
Posted by CalvinKirs <ac...@163.com>.
Hi, I think this is a question worthy of recognition. I think our big pr should be separated, corresponding to an isuess, if it cannot be split, can it be aggregated into an isuess，how do you think？If I am wrong, please correct me
Best regards！
CalvinKirs
On 07/8/2020 22:22，Jave-Chen<ke...@foxmail.com> wrote：
A PR may be associated with multiple issues, so writing Issue No. in PR titile may
be miscellaneous.
------------------ 原始邮件 ------------------
发件人: "Yichao Yang"<1048262223@qq.com>;
发送时间: 2020年7月8日(星期三) 晚上9:29
收件人: "dev"<dev@dolphinscheduler.apache.org>;
主题: [Vote] Pull Request Title Specification
Hi all,
After referring to the practices of other open source communities on the title of pull request, we propose two pre selection schemes for dolphin scheduler.
First：
Specification:
[`Open Source Project Name`-`Issue No`][`Module Name`] `Pull Request Description`
example：
[DS-3333][server] Fix the xxx exception
[DS-3333][server] Implement xxx
...
Second：
Specification:
[`Pull Request Type`-`Issue No`][`Module Name`] `Pull Request Description`
example：
[Fix-3333][server] Fix the xxx exception
[Feature-3333][server] Implement xxx
...
The Pull Request type is shown in the screenshot in [1].
If you agree with the first one as the title of the pull request, reply 1, and the second one reply 2. If there is no other suggestions after 7 days, we will choose the first one.
--------------------------------------------------------
目前参考了其他开源社区的对于 Pull Request 标题的实践之后，针对 DolphinScheduler 我们提出了两种预选的方案：
第一种：
Specification:
[`Open Source Project Name`-`Issue No`][`Module Name`] `Pull Request Description`
example：
[DS-3333][server] Fix the xxx exception
[DS-3333][server] Implement xxx
...
第二种：
Specification:
[`Pull Request Type`-`Issue No`][`Module Name`] `Pull Request Description`
example：
[Fix-3333][server] Fix the xxx exception
[Feature-3333][server] Implement xxx
...
Pull Request Type 类型在 [1] 中截图给出。
如果想选第一种作为Pull request 标题，则回复1，第二种则回复2。没有其他意见或者建议的话，7天之后默认以第一种作为 Pull Request 规范。
[1] Pull Request Type: https://github.com/apache/incubator-dolphinscheduler-website/pull/147
Best,
Yichao Yang