You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by mattyb149 <gi...@git.apache.org> on 2018/08/03 01:41:24 UTC
[GitHub] nifi pull request #2934: NIFI-5484: Fixed PutHive3Streaming to use the Hive ...
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/2934
NIFI-5484: Fixed PutHive3Streaming to use the Hive Metastore URI property (to include multiple URIs)
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-5484
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2934.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2934
----
commit 84876b40a3b4efc1d613db74c89734ad31180617
Author: Matthew Burgess <ma...@...>
Date: 2018-08-03T01:39:48Z
NIFI-5484: Fixed PutHive3Streaming to use the Hive Metastore URI property (to include multiple URIs)
----
---
[GitHub] nifi issue #2934: NIFI-5484: Fixed PutHive3Streaming to use the Hive Metasto...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2934
Thanks @mattyb149! This has been merged to master.
---
[GitHub] nifi pull request #2934: NIFI-5484: Fixed PutHive3Streaming to use the Hive ...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2934#discussion_r207560439
--- Diff: nifi-commons/nifi-utils/src/main/java/org/apache/nifi/processor/util/StandardValidators.java ---
@@ -390,6 +391,19 @@ public ValidationResult validate(final String subject, final String input, final
}
};
+ public static final Validator URI_LIST_VALIDATOR = (subject, input, context) -> {
+
+ if (context.isExpressionLanguageSupported(subject) && context.isExpressionLanguagePresent(input)) {
+ return new ValidationResult.Builder().subject(subject).input(input).explanation("Expression Language Present").valid(true).build();
+ }
+ Optional<ValidationResult> invalidUri = Arrays.stream(input.split(","))
--- End diff --
Good catch, will add a check for null/empty before I start the stream
---
[GitHub] nifi issue #2934: NIFI-5484: Fixed PutHive3Streaming to use the Hive Metasto...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2934
Will review...
---
[GitHub] nifi pull request #2934: NIFI-5484: Fixed PutHive3Streaming to use the Hive ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2934
---
[GitHub] nifi pull request #2934: NIFI-5484: Fixed PutHive3Streaming to use the Hive ...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2934#discussion_r207559164
--- Diff: nifi-commons/nifi-utils/src/main/java/org/apache/nifi/processor/util/StandardValidators.java ---
@@ -390,6 +391,19 @@ public ValidationResult validate(final String subject, final String input, final
}
};
+ public static final Validator URI_LIST_VALIDATOR = (subject, input, context) -> {
+
+ if (context.isExpressionLanguageSupported(subject) && context.isExpressionLanguagePresent(input)) {
+ return new ValidationResult.Builder().subject(subject).input(input).explanation("Expression Language Present").valid(true).build();
+ }
+ Optional<ValidationResult> invalidUri = Arrays.stream(input.split(","))
--- End diff --
I believe the way this stream is set up that an input of empty string would be considered valid.
---