You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/12/27 06:13:38 UTC
[GitHub] [iceberg] ajantha-bhat opened a new pull request, #6496: Core: Minor renaming to avoid engine specific naming in core
ajantha-bhat opened a new pull request, #6496:
URL: https://github.com/apache/iceberg/pull/6496
Just while going through this testcase in core,
felt odd to have an engine-specific naming in the core module as it is common for all the engines/APIs. Hence renamed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] ajantha-bhat commented on pull request #6496: Core: Minor renaming to avoid engine specific naming in core
Posted by GitBox <gi...@apache.org>.
ajantha-bhat commented on PR #6496:
URL: https://github.com/apache/iceberg/pull/6496#issuecomment-1375035464
cc: @Fokko
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] pvary merged pull request #6496: Core: Minor renaming to avoid engine specific naming in core
Posted by GitBox <gi...@apache.org>.
pvary merged PR #6496:
URL: https://github.com/apache/iceberg/pull/6496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] singhpk234 commented on a diff in pull request #6496: Core: Minor renaming to avoid engine specific naming in core
Posted by GitBox <gi...@apache.org>.
singhpk234 commented on code in PR #6496:
URL: https://github.com/apache/iceberg/pull/6496#discussion_r1058592327
##########
core/src/test/java/org/apache/iceberg/TestCatalogUtil.java:
##########
@@ -218,14 +218,14 @@ public void loadCustomMetricsReporter_badClass() {
public static class TestCatalog extends BaseMetastoreCatalog {
private String catalogName;
- private Map<String, String> flinkOptions;
+ private Map<String, String> options;
Review Comment:
[minor] should we call it `catalogProperties` like we do in glue in hive catalog imp ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] pvary commented on pull request #6496: Core: Minor renaming to avoid engine specific naming in core
Posted by GitBox <gi...@apache.org>.
pvary commented on PR #6496:
URL: https://github.com/apache/iceberg/pull/6496#issuecomment-1376778760
Merged to master.
Thanks for the fix @ajantha-bhat and @amogh-jahagirdar for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org