[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2965: Move `byte_size` from datafusion::physical_expr

[GitBox <gi...@apache.org>]

tustvold commented on code in PR #2965:
URL: https://github.com/apache/arrow-rs/pull/2965#discussion_r1008298033


##########
arrow-array/src/record_batch.rs:
##########
@@ -377,6 +377,14 @@ impl RecordBatch {
         let schema = Arc::new(Schema::new(fields));
         RecordBatch::try_new(schema, columns)
     }
+
+    /// Returns the total number of bytes of memory occupied physically by this batch.
+    pub fn byte_size(&self) -> usize {

Review Comment:
   I wonder if we should make clear this only is the size of the arrays and not say the schema? Perhaps we could call it get_array_memory_size?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org