You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by kk...@apache.org on 2011/11/10 01:10:04 UTC
svn commit: r1200056 -
/tomcat/trunk/java/org/apache/catalina/connector/Request.java
Author: kkolinko
Date: Thu Nov 10 00:10:04 2011
New Revision: 1200056
URL: http://svn.apache.org/viewvc?rev=1200056&view=rev
Log:
Change implementation of PARAMETER_PARSE_FAILED_ATTR attribute,
to align with other special attributes. It is now implemented in Request.getAttribute().
Modified:
tomcat/trunk/java/org/apache/catalina/connector/Request.java
Modified: tomcat/trunk/java/org/apache/catalina/connector/Request.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/Request.java?rev=1200056&r1=1200055&r2=1200056&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/connector/Request.java (original)
+++ tomcat/trunk/java/org/apache/catalina/connector/Request.java Thu Nov 10 00:10:04 2011
@@ -884,6 +884,13 @@ public class Request
return null;
}
+ if (name.equals(Globals.PARAMETER_PARSE_FAILED_ATTR)) {
+ if (coyoteRequest.getParameters().isParseFailed()) {
+ return Boolean.TRUE;
+ }
+ return null;
+ }
+
Object attr=attributes.get(name);
if(attr!=null) {
@@ -951,6 +958,7 @@ public class Request
* <li>{@link Globals#KEY_SIZE_ATTR} (SSL connections only)</li>
* <li>{@link Globals#SSL_SESSION_ID_ATTR} (SSL connections only)</li>
* <li>{@link Globals#SSL_SESSION_MGR_ATTR} (SSL connections only)</li>
+ * <li>{@link Globals#PARAMETER_PARSE_FAILED_ATTR}</li>
* </ul>
* The underlying connector may also expose request attributes. These all
* have names starting with "org.apache.tomcat" and include:
@@ -2383,12 +2391,6 @@ public class Request
}
}
- private void checkParameterParseFailed() {
- if (getCoyoteRequest().getParameters().isParseFailed()) {
- setAttribute(Globals.PARAMETER_PARSE_FAILED_ATTR, Boolean.TRUE);
- }
- }
-
public void cometClose() {
coyoteRequest.action(ActionCode.COMET_CLOSE,getEvent());
setComet(false);
@@ -2602,7 +2604,6 @@ public class Request
if (partsParseException != null || !success) {
parameters.setParseFailed(true);
}
- checkParameterParseFailed();
}
}
@@ -2902,7 +2903,6 @@ public class Request
if (!success) {
parameters.setParseFailed(true);
}
- checkParameterParseFailed();
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org