[jira] [Commented] (HIVE-21264) Improvements Around CharTypeInfo

["Gopal V (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-21264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16786354#comment-16786354 ] 

Gopal V commented on HIVE-21264:
--------------------------------

[~belugabehr]: I don't think is correct because varchar(10) != char(10).

{code}
getClass() != other.getClass()
{code}

That was there to prevent it from going and assuming the types are identical.

> Improvements Around CharTypeInfo
> --------------------------------
>
>                 Key: HIVE-21264
>                 URL: https://issues.apache.org/jira/browse/HIVE-21264
>             Project: Hive
>          Issue Type: Improvement
>    Affects Versions: 4.0.0, 3.2.0
>            Reporter: David Mollitor
>            Assignee: David Mollitor
>            Priority: Minor
>         Attachments: HIVE-21264.1.patch, HIVE-21264.2.patch
>
>
> The {{CharTypeInfo}} stores the type name of the data type (char/varchar) and the length (1-255).  {{CharTypeInfo}} objects are often getting cached once they are created.
> The {{hashcode()}} and {{equals()}} of its sub-classes varchar and char are inconsistent.
> * Make hashcode and equals consistent (and fast)
> * Simplify the {{getQualifiedName}} implementation and reduce the scope to protected
> * Other related nits



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)