You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/19 07:23:35 UTC

[GitHub] [arrow] seddonm1 commented on pull request #8966: ARROW-10969: [Rust][DataFusion] Implement basic String ANSI SQL Functions

seddonm1 commented on pull request #8966:
URL: https://github.com/apache/arrow/pull/8966#issuecomment-748433846


   > Overall, this looks really good. Thanks a lot for taking the time to implement these.
   > 
   > I left a lot of comments, but they are all pretty small, so please do not take their number by the correctness of this: you understood and used all the APIs really well, they are just considering edge cases and small consistency improvements.
   
   Thanks @jorgecarleitao and no problem with the number of comments.
   
   I will work through these and let you know.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org