You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Ashutosh Kelkar <as...@clogeny.com> on 2014/02/04 12:15:49 UTC
Review Request 17702: CLOUDSTACK-2232: Adding automation test cases for
Persistent Networks feature
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17702/
-----------------------------------------------------------
Review request for cloudstack and Girish Shilamkar.
Bugs: CLOUDSTACK-2232
https://issues.apache.org/jira/browse/CLOUDSTACK-2232
Repository: cloudstack-git
Description
-------
Adding automation test cases for Persistent Networks feature.
Diffs
-----
test/integration/component/test_persistent_networks.py f61ccaa
tools/marvin/marvin/config/config.cfg 5849fe8
tools/marvin/marvin/integration/lib/base.py 409530c
Diff: https://reviews.apache.org/r/17702/diff/
Testing
-------
Thanks,
Ashutosh Kelkar
Re: Review Request 17702: CLOUDSTACK-2232: Adding automation test cases for
Persistent Networks feature
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17702/#review34655
-----------------------------------------------------------
Ship it!
Ship It!
- Santhosh Edukulla
On Feb. 17, 2014, 7:14 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17702/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2014, 7:14 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-2232
> https://issues.apache.org/jira/browse/CLOUDSTACK-2232
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding automation test cases for Persistent Networks feature.
>
>
> Diffs
> -----
>
> test/integration/component/test_persistent_networks.py f61ccaa
> tools/marvin/marvin/config/config.cfg 7840b7c
> tools/marvin/marvin/integration/lib/base.py aa23029
> tools/marvin/marvin/integration/lib/common.py e202391
>
> Diff: https://reviews.apache.org/r/17702/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 17702: CLOUDSTACK-2232: Adding automation test cases for
Persistent Networks feature
Posted by Girish Shilamkar <gi...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17702/#review35143
-----------------------------------------------------------
Ship it!
Committed to master and 4.3-forward
- Girish Shilamkar
On Feb. 19, 2014, 10:32 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17702/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2014, 10:32 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-2232
> https://issues.apache.org/jira/browse/CLOUDSTACK-2232
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding automation test cases for Persistent Networks feature.
>
>
> Diffs
> -----
>
> test/integration/component/test_persistent_networks.py f61ccaa
> tools/marvin/marvin/config/config.cfg 7840b7c
> tools/marvin/marvin/integration/lib/base.py 1d8229d
> tools/marvin/marvin/integration/lib/common.py 5b56c73
>
> Diff: https://reviews.apache.org/r/17702/diff/
>
>
> Testing
> -------
>
> Adding log:
>
> test_assign_vm_different_account_VR_LB-NS (test_persistent_networks_fixed.TestAssignVirtualMachine) ... skipped 'skip'
> test_assign_vm_different_account_VR_RVR (test_persistent_networks_fixed.TestAssignVirtualMachine) ... skipped 'skip'
> test_assign_vm_different_account_VR_VR (test_persistent_networks_fixed.TestAssignVirtualMachine) ... skipped 'skip'
> test_change_persistent_network_to_non_persistent (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_delete_account (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_list_persistent_network_offering (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_network_state_after_destroying_vms (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_persistent_network_offering_with_VPCVR_services (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_persistent_network_with_RVR (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_pf_nat_rule_persistent_network_LB-Netscaler (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_pf_nat_rule_persistent_network_LB-VR (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_shared_network_offering_with_persistent (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_upgrade_network_NS_to_persistent_NS (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_upgrade_network_VR_to_PersistentRVR (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_upgrade_to_persistent_services_VR_LB-NS (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_upgrade_to_persistent_services_VR_LB-VR (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_vm_deployment_persistent_and_non_persistent_networks (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_vm_deployment_two_persistent_networks (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_account_operations_disabled (test_persistent_networks_fixed.TestProjectAccountOperations) ... ok
> test_account_operations_locked (test_persistent_networks_fixed.TestProjectAccountOperations) ... ok
> test_project_operations (test_persistent_networks_fixed.TestProjectAccountOperations) ... skipped 'Skip'
> test_cleanup_persistent_network_false (test_persistent_networks_fixed.TestRestartPersistentNetwork) ... skipped 'skip'
> test_cleanup_persistent_network_lb_netscaler_false (test_persistent_networks_fixed.TestRestartPersistentNetwork) ... skipped 'skip'
> test_cleanup_persistent_network_lb_netscaler_true (test_persistent_networks_fixed.TestRestartPersistentNetwork) ... skipped 'skip'
> test_cleanup_persistent_network_true (test_persistent_networks_fixed.TestRestartPersistentNetwork) ... skipped 'skip'
> test_vpc_delete_account (test_persistent_networks_fixed.TestVPCNetworkOperations) ... skipped 'skip'
> test_vpc_force_delete_domain (test_persistent_networks_fixed.TestVPCNetworkOperations) ... skipped 'skip'
> test_vpc_network_life_cycle_delete (test_persistent_networks_fixed.TestVPCNetworkOperations) ... skipped 'skip'
> test_vpc_network_life_cycle_restart (test_persistent_networks_fixed.TestVPCNetworkOperations) ... skipped 'skip'
> test_vpc_private_gateway_static_route (test_persistent_networks_fixed.TestVPCNetworkOperations) ... skipped 'skip'
>
> ----------------------------------------------------------------------
> Ran 30 tests in 639.244s
>
> OK (skipped=28)
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 17702: CLOUDSTACK-2232: Adding automation test cases for
Persistent Networks feature
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17702/#review35142
-----------------------------------------------------------
Commit c03fd70ed22d4b0b2ea41fdb923f4432664219d1 in cloudstack's branch refs/heads/4.3-forward from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c03fd70 ]
CLOUDSTACK-2232: Adding automation test cases for Persistent Networks feature
- ASF Subversion and Git Services
On Feb. 19, 2014, 10:32 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17702/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2014, 10:32 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-2232
> https://issues.apache.org/jira/browse/CLOUDSTACK-2232
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding automation test cases for Persistent Networks feature.
>
>
> Diffs
> -----
>
> test/integration/component/test_persistent_networks.py f61ccaa
> tools/marvin/marvin/config/config.cfg 7840b7c
> tools/marvin/marvin/integration/lib/base.py 1d8229d
> tools/marvin/marvin/integration/lib/common.py 5b56c73
>
> Diff: https://reviews.apache.org/r/17702/diff/
>
>
> Testing
> -------
>
> Adding log:
>
> test_assign_vm_different_account_VR_LB-NS (test_persistent_networks_fixed.TestAssignVirtualMachine) ... skipped 'skip'
> test_assign_vm_different_account_VR_RVR (test_persistent_networks_fixed.TestAssignVirtualMachine) ... skipped 'skip'
> test_assign_vm_different_account_VR_VR (test_persistent_networks_fixed.TestAssignVirtualMachine) ... skipped 'skip'
> test_change_persistent_network_to_non_persistent (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_delete_account (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_list_persistent_network_offering (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_network_state_after_destroying_vms (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_persistent_network_offering_with_VPCVR_services (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_persistent_network_with_RVR (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_pf_nat_rule_persistent_network_LB-Netscaler (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_pf_nat_rule_persistent_network_LB-VR (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_shared_network_offering_with_persistent (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_upgrade_network_NS_to_persistent_NS (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_upgrade_network_VR_to_PersistentRVR (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_upgrade_to_persistent_services_VR_LB-NS (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_upgrade_to_persistent_services_VR_LB-VR (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_vm_deployment_persistent_and_non_persistent_networks (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_vm_deployment_two_persistent_networks (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_account_operations_disabled (test_persistent_networks_fixed.TestProjectAccountOperations) ... ok
> test_account_operations_locked (test_persistent_networks_fixed.TestProjectAccountOperations) ... ok
> test_project_operations (test_persistent_networks_fixed.TestProjectAccountOperations) ... skipped 'Skip'
> test_cleanup_persistent_network_false (test_persistent_networks_fixed.TestRestartPersistentNetwork) ... skipped 'skip'
> test_cleanup_persistent_network_lb_netscaler_false (test_persistent_networks_fixed.TestRestartPersistentNetwork) ... skipped 'skip'
> test_cleanup_persistent_network_lb_netscaler_true (test_persistent_networks_fixed.TestRestartPersistentNetwork) ... skipped 'skip'
> test_cleanup_persistent_network_true (test_persistent_networks_fixed.TestRestartPersistentNetwork) ... skipped 'skip'
> test_vpc_delete_account (test_persistent_networks_fixed.TestVPCNetworkOperations) ... skipped 'skip'
> test_vpc_force_delete_domain (test_persistent_networks_fixed.TestVPCNetworkOperations) ... skipped 'skip'
> test_vpc_network_life_cycle_delete (test_persistent_networks_fixed.TestVPCNetworkOperations) ... skipped 'skip'
> test_vpc_network_life_cycle_restart (test_persistent_networks_fixed.TestVPCNetworkOperations) ... skipped 'skip'
> test_vpc_private_gateway_static_route (test_persistent_networks_fixed.TestVPCNetworkOperations) ... skipped 'skip'
>
> ----------------------------------------------------------------------
> Ran 30 tests in 639.244s
>
> OK (skipped=28)
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 17702: CLOUDSTACK-2232: Adding automation test cases for
Persistent Networks feature
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17702/#review35141
-----------------------------------------------------------
Commit 2091211c2828dfd4b6e15eae9c459fbb09b9a27f in cloudstack's branch refs/heads/master from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2091211 ]
CLOUDSTACK-2232: Adding automation test cases for Persistent Networks feature
- ASF Subversion and Git Services
On Feb. 19, 2014, 10:32 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17702/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2014, 10:32 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-2232
> https://issues.apache.org/jira/browse/CLOUDSTACK-2232
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding automation test cases for Persistent Networks feature.
>
>
> Diffs
> -----
>
> test/integration/component/test_persistent_networks.py f61ccaa
> tools/marvin/marvin/config/config.cfg 7840b7c
> tools/marvin/marvin/integration/lib/base.py 1d8229d
> tools/marvin/marvin/integration/lib/common.py 5b56c73
>
> Diff: https://reviews.apache.org/r/17702/diff/
>
>
> Testing
> -------
>
> Adding log:
>
> test_assign_vm_different_account_VR_LB-NS (test_persistent_networks_fixed.TestAssignVirtualMachine) ... skipped 'skip'
> test_assign_vm_different_account_VR_RVR (test_persistent_networks_fixed.TestAssignVirtualMachine) ... skipped 'skip'
> test_assign_vm_different_account_VR_VR (test_persistent_networks_fixed.TestAssignVirtualMachine) ... skipped 'skip'
> test_change_persistent_network_to_non_persistent (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_delete_account (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_list_persistent_network_offering (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_network_state_after_destroying_vms (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_persistent_network_offering_with_VPCVR_services (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_persistent_network_with_RVR (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_pf_nat_rule_persistent_network_LB-Netscaler (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_pf_nat_rule_persistent_network_LB-VR (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_shared_network_offering_with_persistent (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_upgrade_network_NS_to_persistent_NS (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_upgrade_network_VR_to_PersistentRVR (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_upgrade_to_persistent_services_VR_LB-NS (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_upgrade_to_persistent_services_VR_LB-VR (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_vm_deployment_persistent_and_non_persistent_networks (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_vm_deployment_two_persistent_networks (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
> test_account_operations_disabled (test_persistent_networks_fixed.TestProjectAccountOperations) ... ok
> test_account_operations_locked (test_persistent_networks_fixed.TestProjectAccountOperations) ... ok
> test_project_operations (test_persistent_networks_fixed.TestProjectAccountOperations) ... skipped 'Skip'
> test_cleanup_persistent_network_false (test_persistent_networks_fixed.TestRestartPersistentNetwork) ... skipped 'skip'
> test_cleanup_persistent_network_lb_netscaler_false (test_persistent_networks_fixed.TestRestartPersistentNetwork) ... skipped 'skip'
> test_cleanup_persistent_network_lb_netscaler_true (test_persistent_networks_fixed.TestRestartPersistentNetwork) ... skipped 'skip'
> test_cleanup_persistent_network_true (test_persistent_networks_fixed.TestRestartPersistentNetwork) ... skipped 'skip'
> test_vpc_delete_account (test_persistent_networks_fixed.TestVPCNetworkOperations) ... skipped 'skip'
> test_vpc_force_delete_domain (test_persistent_networks_fixed.TestVPCNetworkOperations) ... skipped 'skip'
> test_vpc_network_life_cycle_delete (test_persistent_networks_fixed.TestVPCNetworkOperations) ... skipped 'skip'
> test_vpc_network_life_cycle_restart (test_persistent_networks_fixed.TestVPCNetworkOperations) ... skipped 'skip'
> test_vpc_private_gateway_static_route (test_persistent_networks_fixed.TestVPCNetworkOperations) ... skipped 'skip'
>
> ----------------------------------------------------------------------
> Ran 30 tests in 639.244s
>
> OK (skipped=28)
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 17702: CLOUDSTACK-2232: Adding automation test cases for
Persistent Networks feature
Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17702/
-----------------------------------------------------------
(Updated Feb. 19, 2014, 10:32 a.m.)
Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
Changes
-------
Rebased against latest master.
Bugs: CLOUDSTACK-2232
https://issues.apache.org/jira/browse/CLOUDSTACK-2232
Repository: cloudstack-git
Description
-------
Adding automation test cases for Persistent Networks feature.
Diffs (updated)
-----
test/integration/component/test_persistent_networks.py f61ccaa
tools/marvin/marvin/config/config.cfg 7840b7c
tools/marvin/marvin/integration/lib/base.py 1d8229d
tools/marvin/marvin/integration/lib/common.py 5b56c73
Diff: https://reviews.apache.org/r/17702/diff/
Testing (updated)
-------
Adding log:
test_assign_vm_different_account_VR_LB-NS (test_persistent_networks_fixed.TestAssignVirtualMachine) ... skipped 'skip'
test_assign_vm_different_account_VR_RVR (test_persistent_networks_fixed.TestAssignVirtualMachine) ... skipped 'skip'
test_assign_vm_different_account_VR_VR (test_persistent_networks_fixed.TestAssignVirtualMachine) ... skipped 'skip'
test_change_persistent_network_to_non_persistent (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
test_delete_account (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
test_list_persistent_network_offering (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
test_network_state_after_destroying_vms (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
test_persistent_network_offering_with_VPCVR_services (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
test_persistent_network_with_RVR (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
test_pf_nat_rule_persistent_network_LB-Netscaler (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
test_pf_nat_rule_persistent_network_LB-VR (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
test_shared_network_offering_with_persistent (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
test_upgrade_network_NS_to_persistent_NS (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
test_upgrade_network_VR_to_PersistentRVR (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
test_upgrade_to_persistent_services_VR_LB-NS (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
test_upgrade_to_persistent_services_VR_LB-VR (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
test_vm_deployment_persistent_and_non_persistent_networks (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
test_vm_deployment_two_persistent_networks (test_persistent_networks_fixed.TestPersistentNetworks) ... skipped 'skip'
test_account_operations_disabled (test_persistent_networks_fixed.TestProjectAccountOperations) ... ok
test_account_operations_locked (test_persistent_networks_fixed.TestProjectAccountOperations) ... ok
test_project_operations (test_persistent_networks_fixed.TestProjectAccountOperations) ... skipped 'Skip'
test_cleanup_persistent_network_false (test_persistent_networks_fixed.TestRestartPersistentNetwork) ... skipped 'skip'
test_cleanup_persistent_network_lb_netscaler_false (test_persistent_networks_fixed.TestRestartPersistentNetwork) ... skipped 'skip'
test_cleanup_persistent_network_lb_netscaler_true (test_persistent_networks_fixed.TestRestartPersistentNetwork) ... skipped 'skip'
test_cleanup_persistent_network_true (test_persistent_networks_fixed.TestRestartPersistentNetwork) ... skipped 'skip'
test_vpc_delete_account (test_persistent_networks_fixed.TestVPCNetworkOperations) ... skipped 'skip'
test_vpc_force_delete_domain (test_persistent_networks_fixed.TestVPCNetworkOperations) ... skipped 'skip'
test_vpc_network_life_cycle_delete (test_persistent_networks_fixed.TestVPCNetworkOperations) ... skipped 'skip'
test_vpc_network_life_cycle_restart (test_persistent_networks_fixed.TestVPCNetworkOperations) ... skipped 'skip'
test_vpc_private_gateway_static_route (test_persistent_networks_fixed.TestVPCNetworkOperations) ... skipped 'skip'
----------------------------------------------------------------------
Ran 30 tests in 639.244s
OK (skipped=28)
Thanks,
Ashutosh Kelkar
Re: Review Request 17702: CLOUDSTACK-2232: Adding automation test cases for
Persistent Networks feature
Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17702/
-----------------------------------------------------------
(Updated Feb. 17, 2014, 7:14 a.m.)
Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
Changes
-------
Clubbed lock and disable operation in one function.
Bugs: CLOUDSTACK-2232
https://issues.apache.org/jira/browse/CLOUDSTACK-2232
Repository: cloudstack-git
Description
-------
Adding automation test cases for Persistent Networks feature.
Diffs (updated)
-----
test/integration/component/test_persistent_networks.py f61ccaa
tools/marvin/marvin/config/config.cfg 7840b7c
tools/marvin/marvin/integration/lib/base.py aa23029
tools/marvin/marvin/integration/lib/common.py e202391
Diff: https://reviews.apache.org/r/17702/diff/
Testing
-------
Thanks,
Ashutosh Kelkar
Re: Review Request 17702: CLOUDSTACK-2232: Adding automation test cases for
Persistent Networks feature
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17702/#review34621
-----------------------------------------------------------
tools/marvin/marvin/integration/lib/base.py
<https://reviews.apache.org/r/17702/#comment64807>
One function should suffice i believe as such the internal implementation is not much varied.
- Santhosh Edukulla
On Feb. 14, 2014, 10:38 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17702/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2014, 10:38 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-2232
> https://issues.apache.org/jira/browse/CLOUDSTACK-2232
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding automation test cases for Persistent Networks feature.
>
>
> Diffs
> -----
>
> test/integration/component/test_persistent_networks.py f61ccaa
> tools/marvin/marvin/config/config.cfg 7840b7c
> tools/marvin/marvin/integration/lib/base.py aa23029
> tools/marvin/marvin/integration/lib/common.py e202391
>
> Diff: https://reviews.apache.org/r/17702/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 17702: CLOUDSTACK-2232: Adding automation test cases for
Persistent Networks feature
Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17702/
-----------------------------------------------------------
(Updated Feb. 14, 2014, 10:38 a.m.)
Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
Changes
-------
Review changes.
Bugs: CLOUDSTACK-2232
https://issues.apache.org/jira/browse/CLOUDSTACK-2232
Repository: cloudstack-git
Description
-------
Adding automation test cases for Persistent Networks feature.
Diffs (updated)
-----
test/integration/component/test_persistent_networks.py f61ccaa
tools/marvin/marvin/config/config.cfg 7840b7c
tools/marvin/marvin/integration/lib/base.py aa23029
tools/marvin/marvin/integration/lib/common.py e202391
Diff: https://reviews.apache.org/r/17702/diff/
Testing
-------
Thanks,
Ashutosh Kelkar
Re: Review Request 17702: CLOUDSTACK-2232: Adding automation test cases for
Persistent Networks feature
Posted by Santhosh Edukulla <sa...@citrix.com>.
> On Feb. 12, 2014, 5:23 p.m., Santhosh Edukulla wrote:
> >
Please add test run log. Though, i believe we would have tested it. Making sure tests are run after the changes and working fine.
- Santhosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17702/#review34292
-----------------------------------------------------------
On Feb. 17, 2014, 7:14 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17702/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2014, 7:14 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-2232
> https://issues.apache.org/jira/browse/CLOUDSTACK-2232
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding automation test cases for Persistent Networks feature.
>
>
> Diffs
> -----
>
> test/integration/component/test_persistent_networks.py f61ccaa
> tools/marvin/marvin/config/config.cfg 7840b7c
> tools/marvin/marvin/integration/lib/base.py aa23029
> tools/marvin/marvin/integration/lib/common.py e202391
>
> Diff: https://reviews.apache.org/r/17702/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 17702: CLOUDSTACK-2232: Adding automation test cases for
Persistent Networks feature
Posted by Ashutosh Kelkar <as...@clogeny.com>.
> On Feb. 12, 2014, 5:23 p.m., Santhosh Edukulla wrote:
> > test/integration/component/test_persistent_networks.py, line 670
> > <https://reviews.apache.org/r/17702/diff/1/?file=468548#file468548line670>
> >
> > This step is not visible in test code, is it like enable\disable flag to create network? or offeringid we are passing?
The network offering is created according to the value passed to the test case (LB through VR or LB through Netscaler) and isolated persistent network is created in the next step using that network offering. Please check line 560 (Network creation).
> On Feb. 12, 2014, 5:23 p.m., Santhosh Edukulla wrote:
> > test/integration/component/test_persistent_networks.py, line 304
> > <https://reviews.apache.org/r/17702/diff/1/?file=468548#file468548line304>
> >
> > Not clear with break here, what to do post break. In the tests, we are not checking these cases of return?
We are checking if the VM is expunged or not. When the vm list is empty, that means vm is expunged hence we are breaking and returning. But yes, it is not clearly understandable, I will modify the code to make it lucid.
> On Feb. 12, 2014, 5:23 p.m., Santhosh Edukulla wrote:
> > test/integration/component/test_persistent_networks.py, line 690
> > <https://reviews.apache.org/r/17702/diff/1/?file=468548#file468548line690>
> >
> > Please empty the clean up list after every case in tear down post after cleanup
Done
> On Feb. 12, 2014, 5:23 p.m., Santhosh Edukulla wrote:
> > test/integration/component/test_persistent_networks.py, line 708
> > <https://reviews.apache.org/r/17702/diff/1/?file=468548#file468548line708>
> >
> > We dont check the return of function here.
The function checks if router is accessible or not. We are not returning anything. If router is not accessible, assertion error will be thrown.
> On Feb. 12, 2014, 5:23 p.m., Santhosh Edukulla wrote:
> > test/integration/component/test_persistent_networks.py, line 741
> > <https://reviews.apache.org/r/17702/diff/1/?file=468548#file468548line741>
> >
> > This step is not visible in steps though.
Network is created in the test case. Adding comment to make it more readable.
> On Feb. 12, 2014, 5:23 p.m., Santhosh Edukulla wrote:
> > test/integration/component/test_persistent_networks.py, line 818
> > <https://reviews.apache.org/r/17702/diff/1/?file=468548#file468548line818>
> >
> > Lot of places this code is repeated, may be we can use a small utility function to keep it simple.
Done
> On Feb. 12, 2014, 5:23 p.m., Santhosh Edukulla wrote:
> > test/integration/component/test_persistent_networks.py, line 848
> > <https://reviews.apache.org/r/17702/diff/1/?file=468548#file468548line848>
> >
> > why this code is used two times before and after router list?
It is checking the router accessibility for two different networks. Same variable was used for both the lists that's why confusion. I have changed the names so that it is clear.
> On Feb. 12, 2014, 5:23 p.m., Santhosh Edukulla wrote:
> > test/integration/component/test_persistent_networks.py, line 1072
> > <https://reviews.apache.org/r/17702/diff/1/?file=468548#file468548line1072>
> >
> > If it fails here, account wont be deleted? Dont we add to clean up in case if it fails and during teardown account gets cleaned up?
Account is already added in the cleanup list.
> On Feb. 12, 2014, 5:23 p.m., Santhosh Edukulla wrote:
> > tools/marvin/marvin/integration/lib/base.py, line 125
> > <https://reviews.apache.org/r/17702/diff/1/?file=468550#file468550line125>
> >
> > May be we can control the behavior or true\false using one function only. We don't need both disable and lock i believe
I created two functions just to keep it simple, without adding flags in the same function. So that it is clear what operation we are performing. We can club into same function but then the name of the function will not be that clear as exactly what operation it is performing.
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17702/#review34292
-----------------------------------------------------------
On Feb. 4, 2014, 12:08 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17702/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2014, 12:08 p.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-2232
> https://issues.apache.org/jira/browse/CLOUDSTACK-2232
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding automation test cases for Persistent Networks feature.
>
>
> Diffs
> -----
>
> test/integration/component/test_persistent_networks.py f61ccaa
> tools/marvin/marvin/config/config.cfg 5849fe8
> tools/marvin/marvin/integration/lib/base.py 409530c
>
> Diff: https://reviews.apache.org/r/17702/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 17702: CLOUDSTACK-2232: Adding automation test cases for
Persistent Networks feature
Posted by Ashutosh Kelkar <as...@clogeny.com>.
> On Feb. 12, 2014, 5:23 p.m., Santhosh Edukulla wrote:
> > test/integration/component/test_persistent_networks.py, line 1336
> > <https://reviews.apache.org/r/17702/diff/1/?file=468548#file468548line1336>
> >
> > Is waiting required post disable\lock? or after Account.list?
Yes, because we have to check the "persistent" property of network, for that we will have to wait for cleanup interval post the lock/disable action. We will not catch the bug if we don't wait, because network won't get cleaned up immediately.
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17702/#review34292
-----------------------------------------------------------
On Feb. 14, 2014, 10:38 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17702/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2014, 10:38 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-2232
> https://issues.apache.org/jira/browse/CLOUDSTACK-2232
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding automation test cases for Persistent Networks feature.
>
>
> Diffs
> -----
>
> test/integration/component/test_persistent_networks.py f61ccaa
> tools/marvin/marvin/config/config.cfg 7840b7c
> tools/marvin/marvin/integration/lib/base.py aa23029
> tools/marvin/marvin/integration/lib/common.py e202391
>
> Diff: https://reviews.apache.org/r/17702/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 17702: CLOUDSTACK-2232: Adding automation test cases for
Persistent Networks feature
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17702/#review34292
-----------------------------------------------------------
test/integration/component/test_persistent_networks.py
<https://reviews.apache.org/r/17702/#comment64320>
Not clear with break here, what to do post break. In the tests, we are not checking these cases of return?
test/integration/component/test_persistent_networks.py
<https://reviews.apache.org/r/17702/#comment64323>
This step is not visible in test code, is it like enable\disable flag to create network? or offeringid we are passing?
test/integration/component/test_persistent_networks.py
<https://reviews.apache.org/r/17702/#comment64321>
Please empty the clean up list after every case in tear down post after cleanup
test/integration/component/test_persistent_networks.py
<https://reviews.apache.org/r/17702/#comment64322>
We dont check the return of function here.
test/integration/component/test_persistent_networks.py
<https://reviews.apache.org/r/17702/#comment64324>
This step is not visible in steps though.
test/integration/component/test_persistent_networks.py
<https://reviews.apache.org/r/17702/#comment64325>
Lot of places this code is repeated, may be we can use a small utility function to keep it simple.
test/integration/component/test_persistent_networks.py
<https://reviews.apache.org/r/17702/#comment64326>
why this code is used two times before and after router list?
test/integration/component/test_persistent_networks.py
<https://reviews.apache.org/r/17702/#comment64327>
If it fails here, account wont be deleted? Dont we add to clean up in case if it fails and during teardown account gets cleaned up?
test/integration/component/test_persistent_networks.py
<https://reviews.apache.org/r/17702/#comment64328>
Is waiting required post disable\lock? or after Account.list?
tools/marvin/marvin/integration/lib/base.py
<https://reviews.apache.org/r/17702/#comment64319>
May be we can control the behavior or true\false using one function only. We don't need both disable and lock i believe
- Santhosh Edukulla
On Feb. 4, 2014, 12:08 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17702/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2014, 12:08 p.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-2232
> https://issues.apache.org/jira/browse/CLOUDSTACK-2232
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding automation test cases for Persistent Networks feature.
>
>
> Diffs
> -----
>
> test/integration/component/test_persistent_networks.py f61ccaa
> tools/marvin/marvin/config/config.cfg 5849fe8
> tools/marvin/marvin/integration/lib/base.py 409530c
>
> Diff: https://reviews.apache.org/r/17702/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 17702: CLOUDSTACK-2232: Adding automation test cases for
Persistent Networks feature
Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17702/
-----------------------------------------------------------
(Updated Feb. 4, 2014, 12:08 p.m.)
Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
Bugs: CLOUDSTACK-2232
https://issues.apache.org/jira/browse/CLOUDSTACK-2232
Repository: cloudstack-git
Description
-------
Adding automation test cases for Persistent Networks feature.
Diffs
-----
test/integration/component/test_persistent_networks.py f61ccaa
tools/marvin/marvin/config/config.cfg 5849fe8
tools/marvin/marvin/integration/lib/base.py 409530c
Diff: https://reviews.apache.org/r/17702/diff/
Testing
-------
Thanks,
Ashutosh Kelkar