You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by oshvarts <gi...@git.apache.org> on 2017/02/13 21:19:48 UTC
[GitHub] geode pull request #397: Add junit to try parsing of simple XML file w pool ...
GitHub user oshvarts opened a pull request:
https://github.com/apache/geode/pull/397
Add junit to try parsing of simple XML file w pool ...
...to detect/prevent regression to parsing exceptions that happened
in gemfire 9.0 - 9.0.1.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/oshvarts/geode config-xml-parser2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/397.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #397
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #397: Add junit to try parsing of simple XML file w pool ...
Posted by oshvarts <gi...@git.apache.org>.
Github user oshvarts commented on the issue:
https://github.com/apache/geode/pull/397
@metatype @kirklund could you move this forward please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #397: Add junit to try parsing of simple XML file w pool ...
Posted by metatype <gi...@git.apache.org>.
Github user metatype commented on a diff in the pull request:
https://github.com/apache/geode/pull/397#discussion_r103062304
--- Diff: geode-core/src/test/java/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.java ---
@@ -15,19 +15,25 @@
package org.apache.geode.internal.cache.xmlcache;
import static org.junit.Assert.*;
+import static org.mockito.Mockito.*;
+import static org.apache.geode.distributed.ConfigurationProperties.*;
import java.lang.reflect.Field;
import java.lang.reflect.InvocationTargetException;
import java.lang.reflect.Method;
import java.util.HashMap;
import java.util.Locale;
+import java.util.Properties;
import org.junit.Test;
import org.junit.experimental.categories.Category;
import org.xml.sax.Attributes;
import org.xml.sax.SAXException;
import org.apache.geode.test.junit.categories.UnitTest;
+import org.apache.geode.distributed.internal.membership.gms.mgr.*;
+import org.apache.geode.distributed.DistributedSystem;
+import org.apache.geode.distributed.internal.*;
--- End diff --
I'd prefer to see explicit import statements rather than wildcard imports.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #397: GEODE-2858 - Add junit to try parsing of simple XML...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/397
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #397: Add junit to try parsing of simple XML file w pool ...
Posted by oshvarts <gi...@git.apache.org>.
Github user oshvarts commented on the issue:
https://github.com/apache/geode/pull/397
All checks completed, Travis and spotless are happy, could you accept?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #397: Add junit to try parsing of simple XML file w pool ...
Posted by kirklund <gi...@git.apache.org>.
Github user kirklund commented on the issue:
https://github.com/apache/geode/pull/397
@oshvarts I've pulled this change into one of my local checkouts but I don't see a Geode Jira ticket in any of the git messages. Which ticket is this for? If one doesn't exist, can you please create a Geode Jira ticket describing the bug/wish/improvement that this change is for? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #397: Add junit to try parsing of simple XML file w pool ...
Posted by oshvarts <gi...@git.apache.org>.
Github user oshvarts commented on the issue:
https://github.com/apache/geode/pull/397
fixed wildcards and spotless issue; hopefully fixed the unrelated test failure, though Travis does not seem to be running builds for me to test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #397: GEODE-2858 - Add junit to try parsing of simple XML file w...
Posted by oshvarts <gi...@git.apache.org>.
Github user oshvarts commented on the issue:
https://github.com/apache/geode/pull/397
Jira issue added; pull request renamed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #397: Add junit to try parsing of simple XML file w pool ...
Posted by metatype <gi...@git.apache.org>.
Github user metatype commented on the issue:
https://github.com/apache/geode/pull/397
The test failure doesn't seem to be related to your changes, though you need to run `gradlew spotlessApply` to format your PR correctly. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #397: Add junit to try parsing of simple XML file w pool ...
Posted by metatype <gi...@git.apache.org>.
Github user metatype commented on the issue:
https://github.com/apache/geode/pull/397
@kirklund any thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---