[GitHub] [cloudstack] weizhouapache edited a comment on pull request #4380: RBD: support multiple MON hosts

[GitBox <gi...@apache.org>]

weizhouapache edited a comment on pull request #4380:
URL: https://github.com/apache/cloudstack/pull/4380#issuecomment-704988727


   > The PR currently only contains one commit and just a few changes. This seems incomplete to me.
   > 
   > Where do we generate the Libvirt XML?
   
   @wido this does not require any other code changes in kvm plugin.
   in libvirt pool definition, it uses host ips instead of single host ip.
   
   ```
   <pool type='rbd'>
     <name>uuid</name>
     <uuid>uuid</uuid>
     <capacity unit='bytes'>aaaaaa</capacity>
     <allocation unit='bytes'>aaaaaa</allocation>
     <available unit='bytes'>aaaaaa</available>
     <source>
       <host name='10.11.118.26,10.11.118.27,10.11.118.28' port='6789'/>
       <name>ceph-rbd</name>
       <auth type='ceph' username='cloudstack'>
         <secret uuid='60a41767-1196-3ff3-9105-19de5dc99fce'/>
       </auth>
     </source>
   </pool>
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org