You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Paul Lindner (JIRA)" <ji...@apache.org> on 2008/03/13 08:51:49 UTC

[jira] Created: (SHINDIG-126) Be extra careful when appending minified JS

Be extra careful when appending minified JS
-------------------------------------------

                 Key: SHINDIG-126
                 URL: https://issues.apache.org/jira/browse/SHINDIG-126
             Project: Shindig
          Issue Type: Bug
            Reporter: Paul Lindner
            Assignee: Paul Lindner


When appending minified js files we can end up with code from two files on the same line.

File1.js -->    XX = {"moo" : 10};
jquery.js

Minifying removes the trailing semicolon and newline.

In this case you get 

  XX = {"moo": 10} (function(){if(window.jQuery)var _jQ .....


Fix involves appending ;\n to each javascript file.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (SHINDIG-126) Be extra careful when appending minified JS

Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Brown closed SHINDIG-126.
-------------------------------

    Resolution: Fixed

> Be extra careful when appending minified JS
> -------------------------------------------
>
>                 Key: SHINDIG-126
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-126
>             Project: Shindig
>          Issue Type: Bug
>            Reporter: Paul Lindner
>            Assignee: Paul Lindner
>
> When appending minified js files we can end up with code from two files on the same line.
> File1.js -->    XX = {"moo" : 10};
> jquery.js
> Minifying removes the trailing semicolon and newline.
> In this case you get 
>   XX = {"moo": 10} (function(){if(window.jQuery)var _jQ .....
> Fix involves appending ;\n to each javascript file.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.